Check for keyword function names differently on 1.4+ #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Would be great to also have a test. |
|
Lol turns out I botched the last commit -- I put |
|
Fantastic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JuliaTesting/SimpleMock.jl#11 I found that the names of keyword wrapper functions follow a different scheme starting with Julia 1.4.
I think we can apply the same thing here!
I was hoping that this change would make the
Skippedworkaround in the above PR unnecessary, but that doesn't seem to be the case. I'll probably come up with a good MWE and open a new issue about that later.Closes #161