Conversation
JuliaLang/julia#48766 makes it so this function takes in a world age.
|
Also needs to actually define an overload of |
|
This still has 1 erroring test and 2 failing but that predates this PR. 1.10 now works as well as 1.9. |
|
Can we mark those tests as broken so we can merge this? They don't look important, but I am not sure. |
|
I figure they're not that important given that they're also broken in Julia 1.9 |
|
Unfortunately the errors on 1.9 were actually hiding errors that were happening later on in the code. commit incoming. |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
==========================================
- Coverage 85.38% 81.24% -4.15%
==========================================
Files 6 6
Lines 787 773 -14
==========================================
- Hits 672 628 -44
- Misses 115 145 +30
☔ View full report in Codecov by Sentry. |
|
Looking at the last 2 failures. because I think both old and new answer is correct and it just represents a nonsemantic change in the internals. |
|
Good call. All 1.6 and 1.9 tests are now passing. I believe this is ready to merge. |
JuliaLang/julia#48766 makes it so
retrieve_code_infotakes in a worldage, and dramatically simplifies construction of .