Skip to content

only run precompile workload when generating output#243

Closed
sjkelly wants to merge 1 commit into
JuliaLang:masterfrom
sjkelly:sjk/precomp1
Closed

only run precompile workload when generating output#243
sjkelly wants to merge 1 commit into
JuliaLang:masterfrom
sjkelly:sjk/precomp1

Conversation

@sjkelly

@sjkelly sjkelly commented Apr 19, 2024

Copy link
Copy Markdown

otherwise we run code at module load each time.

otherwise we run code at module load each time.
@KristofferC

Copy link
Copy Markdown
Member

otherwise we run code at module load each time.

This is not really true, the toplevel code only runs during precompilation (or if you load the module and have turned off precompilation).

@StefanKarpinski

Copy link
Copy Markdown
Member

Seems like this change is desirable so that this code isn't run when recompilation is off though, no?

@sjkelly

sjkelly commented Apr 23, 2024

Copy link
Copy Markdown
Author

I should have clarified that the main rationale for this is to make Downloads work at using time with juliac. I am not sure if juliac's compilation model is broken, but I felt that regardless this would be a strict improvement.

I supposed backwards compat needs to be fixed as well.

@sjkelly

sjkelly commented Apr 23, 2024

Copy link
Copy Markdown
Author

Note that #242 is also required for juliac compatibility.

@KristofferC

Copy link
Copy Markdown
Member

This fails on earlier julia versions, I think you need to use the ccall to be compatible.

@sjkelly sjkelly closed this Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants