Equality/hash edge cases for QRCompactWY#1582
Open
jishnub wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
araujoms
reviewed
Apr 29, 2026
| @testset "QRCompactWY equality checks T shape" begin | ||
| # This is a contrived example, but ensures that we don't violate the hash contract | ||
| F = LinearAlgebra.QRCompactWY(zeros(1, 1), reshape([1.0], 1, 1)) | ||
| G = LinearAlgebra.QRCompactWY(zeros(1, 1), reshape([1.0 99.0], 1, 2)) |
Collaborator
There was a problem hiding this comment.
Why is G even valid, though? Shouldn't the constructor just throw an error?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures the we don't accidentally end up with cases where two objects are equal but their hashes differ, or we divide by zero if the matrices are empty.
Co-authored-by: Copilot copilot@github.com