Print the report in color where the stream takes it - #123
KristofferC wants to merge 1 commit into
Conversation
Each package in a color of its own, and a version in the color of the package named before it in its clause, as Pkg's maxsum resolve log does and with the same palette and choice, so a package reads in the same color in both. Color is added to the finished page: without it the page is byte-for-byte what it was. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
=======================================
Coverage ? 95.15%
=======================================
Files ? 12
Lines ? 4025
Branches ? 0
=======================================
Hits ? 3830
Misses ? 195
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I see that this is about color coding the same name consistently, but it took me quite a while to understand that from just looking at the output. The use of red and yellow especially suggests that the colors have something to do with being problematic, whereas the colors don't actually mean that. |
|
It's basically the same color coding strategy as what is in the current resolver, I find it somewhat useful but agree that it is easy to assign some semantic meaning to them. |
|
How about we hold off on this and see if it's missed significantly? |
A report names a handful of packages over and over, and a reader following a chain is tracking which line speaks of which. When
showis given a stream that takes color (get(io, :color, false)), each package now prints in a color of its own and a version in the color of the package it belongs to, the way Pkg's maxsum resolve log does. Without color the page is byte-for-byte what it was.CONFLICT_COLORS = [1:6; 10:14]picked byhash(name)), so a package reads in the same color in both resolvers' output.JSONis not colored insideJSON3, nor1.2inside1.2.3.Before / after
Two conflicts against the General registry (
DataFrames = "1"withPrettyTables = "0.9",Plots = "1.40"withRecipesPipeline = "0.5"):One conflict:
Pkg builds the report with
sprintand so still gets the plain page; passingcontext = stderrthere, as its maxsumlogstrdoes, would turn color on. That is a one-line follow-up on the Pkg side.🤖 Generated with Claude Code