strings/cstring: transcode: prevent Windows sysimage invalidation
#58038
Conversation
Should prevent some sysimage invalidation that happens on 64-bit Windows when running: ```julia struct I <: Integer end function Base.:(<<)(::I, ::Int) end ```
nsajko
added
system:windows
nsajko
changed the title
transcode: prevent some sysimage invalidationtranscode: prevent Windows sysimage invalidation
|
The change prevents these invalidations, tested on Linux with Wine: {
"invalidation_count": 16,
"trees": [
{
"method": "<<(::Main.RawInvalidations.I, ::Int64) @ Main.RawInvalidations \\home\\nsajko\\invalidations\\script\\reproducer.jl:19",
"reason": "inserting",
"mt_backedges": [
{
"type": "Tuple{typeof(<<), Any, Int64}",
"tree": {
"method_instance": {
"method": "transcode(::Type{UInt16}, src::AbstractVector{UInt8}) @ Base strings\\cstring.jl:181",
"method_instance": "MethodInstance for transcode(::Type{UInt16}, ::Base.CodeUnits{UInt8})"
},
"children": [
{
"method_instance": {
"method": "cwstring(s::AbstractString) @ Base strings\\cstring.jl:119",
"method_instance": "MethodInstance for Base.cwstring(::AbstractString)"
},
"children": [
{
"method_instance": {
"method": "memoized_env_lookup(str::AbstractString) @ Base env.jl:8",
"method_instance": "MethodInstance for Base.memoized_env_lookup(::AbstractString)"
},
"children": [
{
"method_instance": {
"method": "_hasenv(s::AbstractString) @ Base env.jl:25",
"method_instance": "MethodInstance for Base._hasenv(::AbstractString)"
},
"children": [
{
"method_instance": {
"method": "in(k::AbstractString, ::Base.KeySet{String, Base.EnvDict}) @ Base env.jl:171",
"method_instance": "MethodInstance for in(::AbstractString, ::Base.KeySet{String, Base.EnvDict})"
},
"children": [
{
"method_instance": {
"method": "haskey(d::AbstractDict, k) @ Base abstractdict.jl:19",
"method_instance": "MethodInstance for haskey(::Base.EnvDict, ::Any)"
},
"children": [
{
"method_instance": {
"method": "versioninfo(io::IO) @ LinearAlgebra Z:\\home\\nsajko\\tmp\\jl\\jl\\windows\\julia-ec424d47ff\\share\\julia\\stdlib\\v1.13\\LinearAlgebra\\src\\LinearAlgebra.jl:774",
"method_instance": "MethodInstance for LinearAlgebra.versioninfo(::IO)"
},
"children": [
{
"method_instance": {
"method": "versioninfo() @ LinearAlgebra Z:\\home\\nsajko\\tmp\\jl\\jl\\windows\\julia-ec424d47ff\\share\\julia\\stdlib\\v1.13\\LinearAlgebra\\src\\LinearAlgebra.jl:774",
"method_instance": "MethodInstance for LinearAlgebra.versioninfo()"
},
"children": [
]
},
{
"method_instance": {
"method": "versioninfo() @ LinearAlgebra Z:\\home\\nsajko\\tmp\\jl\\jl\\windows\\julia-ec424d47ff\\share\\julia\\stdlib\\v1.13\\LinearAlgebra\\src\\LinearAlgebra.jl:774",
"method_instance": "MethodInstance for LinearAlgebra.versioninfo()"
},
"children": [
]
}
]
}
]
}
]
}
]
},
{
"method_instance": {
"method": "access_env(onError::Function, str::AbstractString) @ Base env.jl:27",
"method_instance": "MethodInstance for Base.access_env(::Base.var\"#getindex##11#getindex##12\", ::AbstractString)"
},
"children": [
{
"method_instance": {
"method": "getindex(::Base.EnvDict, k::AbstractString) @ Base env.jl:164",
"method_instance": "MethodInstance for getindex(::Base.EnvDict, ::AbstractString)"
},
"children": [
{
"method_instance": {
"method": "(::LinearAlgebra.var\"#print_var#versioninfo##0\")(io, indent, name) @ LinearAlgebra Z:\\home\\nsajko\\tmp\\jl\\jl\\windows\\julia-ec424d47ff\\share\\julia\\stdlib\\v1.13\\LinearAlgebra\\src\\LinearAlgebra.jl:798",
"method_instance": "MethodInstance for (::LinearAlgebra.var\"#print_var#versioninfo##0\")(::IO, ::String, ::AbstractString)"
},
"children": [
{
"method_instance": {
"method": "versioninfo(io::IO) @ LinearAlgebra Z:\\home\\nsajko\\tmp\\jl\\jl\\windows\\julia-ec424d47ff\\share\\julia\\stdlib\\v1.13\\LinearAlgebra\\src\\LinearAlgebra.jl:774",
"method_instance": "MethodInstance for LinearAlgebra.versioninfo(::IO)"
},
"children": [
]
}
]
}
]
}
]
},
{
"method_instance": {
"method": "access_env(onError::Function, str::AbstractString) @ Base env.jl:27",
"method_instance": "MethodInstance for Base.access_env(::Returns{Symbol}, ::AbstractString)"
},
"children": [
{
"method_instance": {
"method": "get(::Base.EnvDict, k::AbstractString, def) @ Base env.jl:165",
"method_instance": "MethodInstance for get(::Base.EnvDict, ::AbstractString, ::Symbol)"
},
"children": [
{
"method_instance": {
"method": "in(k, v::Base.KeySet) @ Base abstractdict.jl:73",
"method_instance": "MethodInstance for in(::Any, ::Base.KeySet{String, Base.EnvDict})"
},
"children": [
{
"method_instance": {
"method": "haskey(d::AbstractDict, k) @ Base abstractdict.jl:19",
"method_instance": "MethodInstance for haskey(::Base.EnvDict, ::Any)"
},
"children": [
]
}
]
}
]
}
]
}
]
}
]
}
]
}
}
],
"backedges": [
{
"method_instance": {
"method": "<<(x::Integer, c::Int64) @ Base operators.jl:720",
"method_instance": "MethodInstance for <<(::Integer, ::Int64)"
},
"children": [
{
"method_instance": {
"method": "transcode(::Type{UInt16}, src::AbstractVector{UInt8}) @ Base strings\\cstring.jl:181",
"method_instance": "MethodInstance for transcode(::Type{UInt16}, ::Base.CodeUnits{UInt8})"
},
"children": [
]
}
]
}
],
"mt_cache": [
],
"mt_disable": [
]
},
{
"method": ">>(::Main.RawInvalidations.I, ::Int64) @ Main.RawInvalidations \\home\\nsajko\\invalidations\\script\\reproducer.jl:19",
"reason": "inserting",
"mt_backedges": [
{
"type": "Tuple{typeof(>>), Any, Int64}",
"tree": {
"method_instance": {
"method": "transcode(::Type{UInt16}, src::AbstractVector{UInt8}) @ Base strings\\cstring.jl:181",
"method_instance": "MethodInstance for transcode(::Type{UInt16}, ::Base.CodeUnits{UInt8})"
},
"children": [
]
}
}
],
"backedges": [
{
"method_instance": {
"method": ">>(x::Integer, c::Int64) @ Base operators.jl:761",
"method_instance": "MethodInstance for >>(::Integer, ::Int64)"
},
"children": [
{
"method_instance": {
"method": "transcode(::Type{UInt16}, src::AbstractVector{UInt8}) @ Base strings\\cstring.jl:181",
"method_instance": "MethodInstance for transcode(::Type{UInt16}, ::Base.CodeUnits{UInt8})"
},
"children": [
]
}
]
}
],
"mt_cache": [
],
"mt_disable": [
]
}
]
} |
|
Is it possible to figure out why getindex on We could fix there. |
I looked into that already, but couldn't find anything to improve in that direction. It could be fixed by adding a typeassert to the julia> methods(getindex, Tuple{Base.CodeUnits{UInt8}, Int})
# 1 method for generic function "getindex" from Base:
[1] getindex(s::Base.CodeUnits, i::Int64)
@ strings/basic.jl:803
julia> code_typed(getindex, Tuple{Base.CodeUnits{UInt8}, Int}; debuginfo=:source)
1-element Vector{Any}:
CodeInfo(
@ strings/basic.jl:803 within `getindex`
┌ @ Base_compiler.jl:55 within `getproperty`
1 ─│ %1 = builtin Base.getfield(s, :s)::AbstractString
│ └
│ %2 = dynamic Base.codeunit(%1, i)::Any
└── return %2
) => Any
Done already, however I suppose it's better to be thorough and fix on multiple places on the call chain: |
Maybe, I mean the only reason you find these in particular is because they end up getting called by type unstable code that ends up in the sysimage. Otherwise, you would annotate every |
My reasoning is that in the future some other piece of type unstable code could be added, eventually calling
Not quite:
|
|
What exactly is the issue here? If it's code duplication, I could introduce an additional local function like If this seems useless after the LinearAlgebra.jl PR is merged, as far as I understand it should still be useful for released versions of Julia, |
It doesn't to me feel like his function does anything wrong. The only reason you are changing these is because of some badly written code in stdlibs, or?
You can just make the same fix here in stdlib/LinearAlgebra? |
|
|
Oh, you mean to make a PR to the v1.11 backports branch, modifying the LinearAlgebra code there directly? |
Perhaps not wrong, however I guess it can do better, to be more resistant to invalidation? |
Should prevent all sysimage invalidation that happens on 64-bit Windows when running: