Skip to content

Update for Manifolds.jl 0.11 and Runic.jl formatting - #11

Open
mateuszbaran wants to merge 8 commits into
mainfrom
mbaran/update-deps-Manifolds-v0.11
Open

Update for Manifolds.jl 0.11 and Runic.jl formatting#11
mateuszbaran wants to merge 8 commits into
mainfrom
mbaran/update-deps-Manifolds-v0.11

Conversation

@mateuszbaran

Copy link
Copy Markdown
Member

Sadly, something doesn't seem to be AD-able in the new code and I've switched do finite differences for now.

Comment thread docs/make.jl Outdated

@kellertuer kellertuer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just maybe check with the other documentations and their projects how this “please load the package from the parent folder” can be simplified a bit.

@kellertuer

Copy link
Copy Markdown
Member

Oh and if you want to also switch to the pure-Julia notebook runner you do not need a Jupyter Julia version but just have to specify an engine (namely Julia) in the _quarto.yml

@mateuszbaran

Copy link
Copy Markdown
Member Author

Thanks, something like that?

@kellertuer

kellertuer commented Oct 9, 2025

Copy link
Copy Markdown
Member

at least at first glance make.jl and the new quarto setup look correct :)

@codecov

codecov Bot commented Oct 9, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.80%. Comparing base (d499a7a) to head (91d3b5f).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
src/processes/car_sphere.jl 0.00% 4 Missing ⚠️
src/processes/rotating_earth.jl 0.00% 3 Missing ⚠️
src/filters.jl 66.66% 1 Missing ⚠️
src/processes/general.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   64.94%   64.80%   -0.14%     
==========================================
  Files           8        8              
  Lines         425      429       +4     
==========================================
+ Hits          276      278       +2     
- Misses        149      151       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mateuszbaran

Copy link
Copy Markdown
Member Author

Hm, there is still something wrong with docs here. Could you check it @kellertuer ? I will check ManifoldDiffEq.jl.

@mateuszbaran

Copy link
Copy Markdown
Member Author

The example in docs is doing something completely not right 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants