Skip to content

Generalized Cauchy direction and box constraints - #554

Merged
mateuszbaran merged 150 commits into
dev-0.6from
mbaran/gcp
May 13, 2026
Merged

Generalized Cauchy direction and box constraints#554
mateuszbaran merged 150 commits into
dev-0.6from
mbaran/gcp

Conversation

@mateuszbaran

@mateuszbaran mateuszbaran commented Nov 28, 2025

Copy link
Copy Markdown
Member

This is a WIP PR that implements the GCP idea to L-BFGS and maybe some other solvers, so that they can be used in the presence of box constraints on the Euclidean part of the manifold. The constraints are handled similarly to L-BFGS-B (although not all Euclidean tricks are applied).

TODO:

  • a full example of working with a box domain
  • code coverage

The implementation was prepared in collaboration with @paprzybysz .

@mateuszbaran mateuszbaran added enhancement WIP Work in Progress (for a pull request) labels Nov 28, 2025
@codecov

codecov Bot commented Nov 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (dev-0.6@00c160b). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             dev-0.6      #554   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?        91           
  Lines              ?     11631           
  Branches           ?         0           
===========================================
  Hits               ?     11631           
  Misses             ?         0           
  Partials           ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/plans/stopping_criterion.jl Outdated
@kellertuer
kellertuer changed the base branch from master to dev-0.6 April 7, 2026 08:30
@kellertuer

Copy link
Copy Markdown
Member

Since this will also be part of the next major version 0.6, I diverted the base branch (this merges into) already to dev-0.6; I can also resolve the conflicts somewhen the next few days.

kellertuer and others added 7 commits April 8, 2026 09:48
# Conflicts:
#	Changelog.md
#	src/helpers/LineSearchesTypes.jl
#	src/plans/stepsize/linesearch.jl
#	src/plans/stepsize/stepsize.jl
#	src/plans/stopping_criterion.jl
#	test/plans/test_stepsize.jl
#	test/plans/test_stopping_criteria.jl
#	test/solvers/test_quasi_Newton.jl
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.45.0 to 1.45.1.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.45.0...v1.45.1)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-version: 1.45.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump julia-actions/setup-julia from 2 to 3

Bumps [julia-actions/setup-julia](https://github.com/julia-actions/setup-julia) from 2 to 3.
- [Release notes](https://github.com/julia-actions/setup-julia/releases)
- [Commits](julia-actions/setup-julia@v2...v3)

---
updated-dependencies:
- dependency-name: julia-actions/setup-julia
  dependency-version: '3'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* remove arch keyword since by now they all should run on 64 bit and it was too restructive for mac os

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ronny Bergmann <git@ronnybergmann.net>
kellertuer and others added 7 commits April 24, 2026 14:09
* introduce a stopped_at function for solver states.
* Add stopped_at to the docs.
* Add the AI section to the initial TOC.
* a bit of code formatting and one test.
* Fix a test.
…art (#604)

* refactor CGRule
* Fix some issues with CG + HZ
* provide a proper test + formatting
* fix CG test
* Refactor CG rules.
* Fix 2 cases where we implicitly relied on storage being updated in case it was not filled and now fill it explicitly.
* bump version.

---------

Co-authored-by: Ronny Bergmann <git@ronnybergmann.net>
# Conflicts:
#	Changelog.md
#	src/plans/conjugate_gradient_plan.jl
#	test/plans/test_conjugate_gradient_plan.jl
#	test/solvers/test_gradient_descent.jl
Comment thread ext/ManoptManifoldsExt/manifold_functions.jl Outdated
@mateuszbaran
mateuszbaran merged commit dbc1da0 into dev-0.6 May 13, 2026
13 of 16 checks passed
kellertuer referenced this pull request Jun 24, 2026
@kellertuer
kellertuer deleted the mbaran/gcp branch June 26, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Ready-for-Review A label for pull requests that are feature-ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow specifying a small positive constant as the lower limit of y-s products in QN

4 participants