Leverage Base reduction functions for sum#37
Open
asinghvi17 wants to merge 8 commits intoJuliaMath:masterfrom
Open
Leverage Base reduction functions for sum#37asinghvi17 wants to merge 8 commits intoJuliaMath:masterfrom
asinghvi17 wants to merge 8 commits intoJuliaMath:masterfrom
Conversation
Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 56 64 +8
=========================================
+ Hits 56 64 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@simonbyrne any objection? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implementation of #7 with some extra tests. I could use Kahan summation in some GeometryOps.jl things I am doing, especially the
sum_kbn(f, itr)form.I attached a timer output and it never calls the method for two TwicePrecisions. (Annotations mine)