Skip to content

ci: skip JET with pre #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
inkydragon wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

ci: skip JET with pre #518

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6fe1754
test: move JET into `jet.jl`, run test if `VERSION < v"1.13"`
inkydragon Feb 6, 2026
7761124
ci: skip JET with `pre`
inkydragon Feb 9, 2026
ee4168a
ci: fix Pkg op
inkydragon Feb 9, 2026
edf8abb
ci: Remove JET from Project.toml using sed
inkydragon Feb 12, 2026
dec4514
ci: remove JET from compat
inkydragon Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ jobs:
with:
version: ${{ matrix.version }}
- uses: julia-actions/cache@v2
- name: Remove JET
# Update this condition when JET support new version
Copy link
Member

@devmotion devmotion Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right place for this "fix". One must fix the registry instead.

Copy link
Member Author

@inkydragon inkydragon Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know that.
But I don't see any chance of this issue being fixed upstream anytime soon.

The pre-CI did indeed uncover some new problems.

Another idea: treat this PR as a pre-CI for master without merge it.
We just need to update or rebase this branch.

Copy link
Member

@devmotion devmotion Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I don't see any chance of this issue being fixed upstream anytime soon.

Maybe you could open a PR? I don't care too much about these test failures, so I haven't spent time on it. But it should be fairly trivial.

Copy link
Member

@devmotion devmotion Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally wonder though how useful CI on pre-release versions is. See e.g. also the discussion in JuliaStats/StatsFuns.jl#194 (comment)

if: matrix.version == 'pre'
shell: julia --project --color=yes {0}
run: |
using Pkg
Pkg.rm("JET")
Copy link
Member Author

@inkydragon inkydragon Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, seems we cannot remove Pkgs from [extras]

JuliaLang/Pkg.jl#3741

Copy link
Member Author

@inkydragon inkydragon Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do some ugly things.

- uses: julia-actions/julia-buildpkg@v1
- uses: julia-actions/julia-runtest@v1
- uses: julia-actions/julia-processcoverage@v1
Expand Down
17 changes: 17 additions & 0 deletions test/jet.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
using JET: JET

@testset "package" begin
# Check that there are no undefined global references and undefined field accesses
JET.test_package(SpecialFunctions; target_defined_modules = true, mode = :typo)

# Analyze methods based on their declared signature
JET.report_package(SpecialFunctions; target_defined_modules = true)
end

@testset "logabsgamma" begin
# issue #502
JET.@test_call logabsgamma(1.0)
JET.@test_opt logabsgamma(1.0)
JET.@test_call logabsgamma(1f0)
JET.@test_opt logabsgamma(1f0)
end
8 changes: 0 additions & 8 deletions test/logabsgamma.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,3 @@ x = 8.000001f0
# (i.e. prevfloat(8.000001f0) == 8.0f0)
# We still check appropriate behavior at 8.0f0
@test ulp(8.0f0) < 0.4006594736129046

@testset "JET" begin
# issue #502
JET.@test_call logabsgamma(1.0)
JET.@test_opt logabsgamma(1.0)
JET.@test_call logabsgamma(1f0)
JET.@test_opt logabsgamma(1f0)
end
8 changes: 0 additions & 8 deletions test/qa.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,3 @@ end
# No self-qualified accesses
@test ExplicitImports.check_no_self_qualified_accesses(SpecialFunctions) === nothing
end

@testset "JET" begin
# Check that there are no undefined global references and undefined field accesses
JET.test_package(SpecialFunctions; target_defined_modules = true, mode = :typo)

# Analyze methods based on their declared signature
JET.report_package(SpecialFunctions; target_defined_modules = true)
end
9 changes: 8 additions & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ using Base.MathConstants: γ

using Aqua: Aqua
using ExplicitImports: ExplicitImports
using JET: JET

using SpecialFunctions: AmosException, f64

Expand Down Expand Up @@ -50,3 +49,11 @@ for t in tests
include(tp)
end
end

# Update this condition when JET support new version
# https://github.com/aviatesk/JET.jl/blob/master/Project.toml
if VERSION < v"1.13"
@testset "JET" begin
include(joinpath(testdir, "jet.jl"))
end
end
Loading