Restrict * methods for SimplePoly to Number's - #539
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #539 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 14 14
Lines 3016 3016
=======================================
Hits 2850 2850
Misses 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
AFAICT the test failures are unrelated. |
This avoids invalidating other methods.
devmotion
reviewed
Aug 5, 2026
Comment on lines
+8
to
+9
| Base.:*(p::SimplePoly, c::Number) = SimplePoly(p.coeffs * c) | ||
| Base.:*(c::Number, p::SimplePoly) = p * c |
Member
There was a problem hiding this comment.
Do we actually need both forms? AFAICT SimplePoly is completely internal, so likely one form should be sufficient?
Contributor
Author
There was a problem hiding this comment.
I think that's a question for you and the other maintainers, I'm not at all familiar with the internals 😅 When it comes to invalidations I don't think it would matter.
devmotion
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it should still be ok for differentiating through
expint()with ForwardDiff, sinceDual <: Real.Fixes these invalidations seen when loading CurveFit.jl on 1.13: