Skip to content

ictab#43

Merged
palday merged 8 commits intomainfrom
p/aictab
Aug 29, 2025
Merged

ictab#43
palday merged 8 commits intomainfrom
p/aictab

Conversation

@palday
Copy link
Member

@palday palday commented Aug 28, 2025

inspired by @bbolker

palday and others added 3 commits August 28, 2025 21:09
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b21b3a0) to head (d9755f6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines          115       126   +11     
=========================================
+ Hits           115       126   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bbolker
Copy link

bbolker commented Aug 28, 2025

nice. Two very quick comments:

  • "moe3l" for "model typo" in src/tables.jl
  • the string representation of the model formula is often quite long. It can be nice to allow a user-specified shortname.

The R idiom for this would be that the default for tbl = aictab(a, b, c, d) would use deparse(substitute(.)) to extract the symbol name, and use these by default: the more sophisticated R idiom would be to allow named kwargs (i.e. tbl = aictab(a, b, c, fourth_model=d))

ictab might be a more appropriate/general name since the table contains several different information-theoretic criteria (but aictab might be more familiar)

For possible reference/interest: https://github.com/bbolker/bbmle/blob/master/man/ICtab.Rd

@palday palday changed the title aictab ictab Aug 28, 2025
palday and others added 3 commits August 28, 2025 20:00
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@palday palday merged commit d72f611 into main Aug 29, 2025
8 checks passed
@palday palday deleted the p/aictab branch August 29, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants