Skip to content

Add a precompilation workload #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JamesWrigley
Copy link

On my system this reduces the time taken for a subset of the curve fitting tests from ~12.5s to ~2.5s.

Note that support for BigFloat's is currently broken with NLSolversBase 7.9 so CI won't pass (hacky fix here JuliaNLSolvers/NLSolversBase.jl#160, but @gdalle kindly agreed to look into it further).

@pkofod
Copy link
Member

pkofod commented Apr 7, 2025

If big float support broke because of the NLSolversBase release we should bound the version that is supported by v.0.15.x of LsqFit.jl

@devmotion
Copy link

It would indeed be interesting to know whether it worked prior to the recent changes. I saw that @lcontento had encountered the seemingly same issue (I opened a PR with a fix to ForwardDiff) in NLsolve 5 years ago: JuliaDiff/ForwardDiff.jl#436

@gdalle
Copy link

gdalle commented Apr 7, 2025

Yeah it worked because NLSolversBase used y = copy(...) instead of y = similar(...) before the DI integration came along. But I think the right fix is the one in ForwardDiff JuliaDiff/ForwardDiff.jl#743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants