Skip to content

Conversation

@giordano
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.24%. Comparing base (def2fd9) to head (fd7d08f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   94.73%   98.24%   +3.50%     
==========================================
  Files           1        1              
  Lines          57       57              
==========================================
+ Hits           54       56       +2     
+ Misses          3        1       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@giordano
Copy link
Member Author

giordano commented Nov 29, 2025

There are various failures, but

OutputCollectors.jl: Test Failed at /Users/runner/work/OutputCollectors.jl/OutputCollectors.jl/test/runtests.jl:49
  Expression: output_str == stdout_msg * "\n" * stderr_msg * "\n"
   Evaluated: "Print to stderr\nPrint to stdout\n" == "Print to stdout\nPrint to stderr\n"
[...]
OutputCollectors.jl: Test Failed at /Users/runner/work/OutputCollectors.jl/OutputCollectors.jl/test/runtests.jl:50
  Expression: output_colored_str == stdout_msg * "\n" * red * stderr_msg * "\n" * default
   Evaluated: "\e[31mPrint to stderr\n\e[39mPrint to stdout\n" == "Print to stdout\n\e[31mPrint to stderr\n\e[39m"

Should these test that the output contains stderr/stdout separately, rather than in the specific order? Although I'm a bit surprised stderr comes before stdout given that the code is

stdout_msg = "Print to stdout"
stderr_msg = "Print to stderr"
cmd = """
echo $(stdout_msg)
echo $(stderr_msg) > /dev/stderr
"""

@giordano
Copy link
Member Author

This is still necessary on master (but tests are also failing....)

@giordano giordano reopened this Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants