Skip to content

Add force option to path macro#34

Open
sharanry wants to merge 1 commit into
JuliaPackaging:mainfrom
sharanry:sy/add_force
Open

Add force option to path macro#34
sharanry wants to merge 1 commit into
JuliaPackaging:mainfrom
sharanry:sy/add_force

Conversation

@sharanry
Copy link
Copy Markdown

Current API does not allow to us forcefully use the contents stored in the Path object regardless of whether the path exists or not. This PR enables such use.

It is especially useful when the path stored exists but does not have the right permissions.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 29, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.80%. Comparing base (73e64ae) to head (bc53ecf).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files           1        1           
  Lines          61       61           
=======================================
  Hits           56       56           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MichaelHatherly
Copy link
Copy Markdown
Collaborator

It is especially useful when the path stored exists but does not have the right permissions.

Thanks @sharanry, would you mine expanding on this a bit further? What kind of situation is this coming up in?

And does it have any relation to #32 at all?

@sharanry
Copy link
Copy Markdown
Author

sharanry commented Oct 30, 2023

@MichaelHatherly

I do think #32 is related but the functionality it aims to add does not solve the scenario I am trying to solve.

For some context which has already been mentioned before, in #32 @fredrikekre mentions

packages that are Pkg.added (the package manager makes all files read only)

This is exactly the scenario I am trying to tackle through this PR. The files from packages which are added end up becoming read-only and become troublesome to work with. This PR enables us to have relaxed permissions as we make sure to use files stored within the Path object which end up getting regenerated during runtime in the scratch space with the read-write permissions.

I am of the opinion that we need to keep the permissions of the files captured by the Path object configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants