[Tracy] Update to v0.10 #11089
[Tracy] Update to v0.10 #11089
Conversation
| if [[ "${target}" != *-mingw* ]]; then | ||
| echo "target_compile_definitions(TracyClient PUBLIC __STDC_FORMAT_MACROS)" >> CMakeLists.txt | ||
| else | ||
| echo "target_compile_definitions(TracyClient PUBLIC WINVER=0x0602 _WIN32_WINNT=0x0602)" >> CMakeLists.txt |
There was a problem hiding this comment.
Why? We already define these macros at newer values: https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/45acaa5c78a091ef75e5daa5de7a8676600509a5/src/Runner.jl#L555
There was a problem hiding this comment.
No idea, this was added by @topolarity for v0.9 in #6087 and I just copy-pasted.
Do you mean that I can just remove this 5 lines now ?
There was a problem hiding this comment.
It's also in line 26 of T/TracyProfiler/build_tarballs.jl
There was a problem hiding this comment.
This was probably copied from https://github.com/JuliaLang/julia/blob/master/deps/libtracyclient.mk (which will also need an update together with this Yggdrasil recipe)
blegat
changed the title
|
I targetted v0.10 in order to be compatible with #8437 but since I do both at the same time in this PR, we could target v0.11.1 directly so that we are up to date. The issue is that they removed the old Makefiles in wolfpld/tracy@7f8a2e2 so we need to change the build script to use CMake now so I made a separate PR to update to v0.11.1 #11097 |
|
|
||
| # Collection of sources required to complete build | ||
| sources = [ | ||
| GitSource("https://github.com/wolfpld/tracy.git", | ||
| "897aec5b062664d2485f4f9a213715d2e527e0ca"), # v0.9.1 | ||
| "5d542dc09f3d9378d005092a4ad446bd405f819a"), # v0.11.1 | ||
| ArchiveSource("https://github.com/phracker/MacOSX-SDKs/releases/download/11.3/MacOSX11.0.sdk.tar.xz", |
There was a problem hiding this comment.
Not sure if I should update this ? grep tells me that a few builds in Yggdrasil are using a more recent version : 13.3
blegat
changed the title
blegat
force-pushed
the
[email protected]
branch
from
67ddac5 to
014fa6a
Compare
To be merged at the same time as #8437 to avoid breakage.
Among the 4 patches needed for v0.9.1, I could remove three patches who are part of v0.10
TRACY_NO_SAMPLINGfor sys-tracing wolfpld/tracy#545