[OCaml] Add (cross-)compiler shards #11146
Conversation
|
|
||
| include("../common.jl") | ||
|
|
||
| name = "OCamlBase" |
There was a problem hiding this comment.
Not sure if this should be OCaml or something else
Is there a convention?
There was a problem hiding this comment.
Good question. I think for Go we just use "Go"?
There was a problem hiding this comment.
Just "OCaml" sounds good to me.
It won't conflict with the OCaml_jll, will it?
There was a problem hiding this comment.
No, this isn't published as a regular JLL package, but only as a release in this repo. Note that you'll need to have BinaryBuilderBase deved in your environment, the script will modify your Artifacts.toml file.
| compiler_target = try | ||
| parse(Platform, ARGS[end]) | ||
| catch | ||
| error("This is not a typical build_tarballs.jl! Must provide exactly one platform as the last argument!") | ||
| end |
There was a problem hiding this comment.
I opted to go the GCC route and use the compiler target as the "target" for the build
(even though the toolchain we use during the build is the host toolchain for the most part, we do need both)
topolarity
force-pushed
the
ct/ocaml-shards
branch
2 times, most recently
from
2a8a536 to
f9e5b2f
Compare
|
I noticed during this process that I also need to declare a runtime dependency on I don't know whether that's necessary for these shards, since that dependency should be handled pretty much automatically (unless someone specifically excludes the |
topolarity
force-pushed
the
ct/ocaml-shards
branch
from
f9e5b2f to
cb8db63
Compare
|
I think I have most of the bones in-place here @giordano should I start generating + uploading these shards, or is there something else to do first? |
|
Uhm, no, I think building and publishing the shards should be good now. |
I'm sure there's plenty that needs fixing here, but the main build is working at least. I also had to move to a pre-release of v5.4.0 since OCaml's cross-compiler support was only recently shored up in Dec 2024 (great timing for us!)
companion PR's: JuliaPackaging/BinaryBuilderBase.jl#425 and JuliaPackaging/BinaryBuilder.jl#1382