Skip to content

[aws_c_sdkutils] Update to version 0.2.4 #11201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quinnj2
Copy link
Contributor

@quinnj2 quinnj2 commented May 15, 2025

This PR updates aws_c_sdkutils to version 0.2.4. cc: @quinnj @Octogonapus

@@ -38,7 +38,7 @@ products = [
dependencies = [
Dependency("aws_c_cal_jll"; compat="0.8.3"),
Dependency("aws_c_http_jll"; compat="0.9.3"),
Dependency("aws_c_sdkutils_jll"; compat="0.2.3"),
Dependency("aws_c_sdkutils_jll"; compat="0.2.4"),
Copy link
Member

@giordano giordano May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need to update the version number of the package. But also, changing the compat 0.2.3 -> 0.2.4 is likely unnecessary, it's more important when changing across breaking version (e.g. if jumping to 0.3)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my thought process:

  • I'm not super worried in this case about doing a new build/release of aws_c_auth, because it hasn't actually had a new release
  • But the next time it does have a release, I'd ideally use the latest version of all dependencies (that's how they have the aws crt libraries set up to work in practice, each essentially relying on the latest version of deps)
  • But instead of having to go out and parse all the latest versions of each dependency on each new release, I'll just update any downstream dependencies when an upstream has a new release.

Does that sound like an ok plan?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, but now I see that it's still trying to build the aws_c_auth library; is there a way I can add a comment to only build a single designated library? or to skip the others?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's all or nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants