Skip to content

Conversation

@amontoison
Copy link
Contributor

Thanks @amd-agodbole for working in this!

cc @imciner2 @giordano @ViralBShah

@ViralBShah
Copy link
Member

This looks straightforward enough to merge.

@imciner2
Copy link
Member

I was going to give this a look over tomorrow, because I want to see if we can use the install command instead of cp for the files.

Comment on lines +12 to +13
GitSource("https://github.com/amd/AOCL_jll.jl.git",
"d3bffce6129bd77cde3f68adb9b03a44b82cfba2"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, but for future versions of AOCL we will need a better place to download the license files from. @amd-agodbole is there someplace on the website where we could download each file? We could then use a FileSource to get the licenses.

Or actually, are these PDF files just a copy of the LICENSE and NOTICES files in the various repos (e.g., https://github.com/amd/blis/blob/master/LICENSE and https://github.com/amd/blis/blob/master/NOTICES)? If so, we could use those.

ViralBShah and others added 4 commits October 30, 2025 11:33
@ViralBShah
Copy link
Member

@aelobdog Are binaries available for Windows - or are these linux only?

@imciner2
Copy link
Member

imciner2 commented Oct 30, 2025

@aelobdog Are binaries available for Windows - or are these linux only?

There are Windows binaries available, but the ones on the AMD site are some sort of self-extracting installation tool that we can't just extract in our sandbox, so we can't get the binaries from them.

We either need AMD to provide a tarball redistributable package for the Windows libraries (like is done for Linux), or I guess we could repackage the three conda-forge AOCL packages to get the libraries for Windows - but I think those are only one of the versions (and I can't tell if it is LP64 or ILP64).

The Conda-forge packages are https://anaconda.org/conda-forge/aocl-blas/files, https://anaconda.org/conda-forge/aocl-lapack/files and https://anaconda.org/conda-forge/aocl-utils/files.

@ViralBShah
Copy link
Member

As an FYI, for MKL, we do repackage the conda forge versions.

@imciner2
Copy link
Member

I looked at the feedstock for the conda forge package, and they just build the library themselves actually - but only one version of it (whatever integer size is the default for the CMake build system): https://github.com/conda-forge/aocl-blas-feedstock/blob/main/recipe/build_aoclblas.bat. So I don't think we can just repackage the conda forge one (I think it might be LP64 only actually).

@ViralBShah
Copy link
Member

Should we also be building from source - if source is available?

@imciner2
Copy link
Member

Should we also be building from source - if source is available?

The source is available, and there was a start at a recipe building from source in #11896. The thing with that source build is I was worried about the performance of the library versus compatibility with the C++ runtime library (needing too new a library), because we would need the newer GCC versions to get the architectures (GCC 12 is Zen 3, GCC 14 is Zen 5). That said, I think it could be worth doing some profiling of this build versus the source build in #11896 to see if there are any performance differences on the newer architectures (especially Zen 5) - since I think most of the critical parts would be in assembly kernels, that might not acutally be a large issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants