Open
Conversation
Member
|
Why not build for all supported platforms? |
imciner2
reviewed
Mar 2, 2026
Comment on lines
+23
to
+24
| # Meson fails to detect the macOS/aarch64 linker in BinaryBuilder; | ||
| # build manually here. |
Member
There was a problem hiding this comment.
We haven't seen errors with this before - what is the exact error you saw with Meson on aarch64 macOS?
Comment on lines
+9
to
+13
| ArchiveSource( | ||
| "https://raw.githubusercontent.com/jonasson2/randompack-src/v0.1.1/randompack-0.1.1.tar.gz", | ||
| "db3f048ddce772a77cacdf2d23a6bed58db4836b9d60f3dc6d1d910662926294", | ||
| ), | ||
| ] |
Member
There was a problem hiding this comment.
This repo is literally just a tarball. Is there a repo that tracks the actual code files?
| Platform("x86_64", "macos", libgfortran_version="5.0.0"), | ||
| Platform("x86_64", "linux"; libgfortran_version="5.0.0", cxxstring_abi="cxx11"), | ||
| Platform("aarch64", "linux"; libgfortran_version="5.0.0", cxxstring_abi="cxx11"), | ||
| Platform("x86_64", "windows"; libgfortran_version="5.0.0"), |
Member
There was a problem hiding this comment.
This list is overly specific, like specifically why is this requesting a libgfortran version, but the Meson was told not to build the Fortran interface?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New package: Randompack, a random number generation library.