Skip to content

[numav_julia] New package#13852

Merged
fingolfin merged 4 commits into
JuliaPackaging:masterfrom
mmfiuza:numav
Jun 3, 2026
Merged

[numav_julia] New package#13852
fingolfin merged 4 commits into
JuliaPackaging:masterfrom
mmfiuza:numav

Conversation

@mmfiuza
Copy link
Copy Markdown
Contributor

@mmfiuza mmfiuza commented Jun 1, 2026

Numav is a C++ library under development to perform acoustics and vibrations simulations, binded with CxxWrap.

Comment thread N/numav_julia/build_tarballs.jl Outdated
Comment thread N/numav_julia/build_tarballs.jl Outdated
@mmfiuza mmfiuza marked this pull request as draft June 2, 2026 12:37
mmfiuza and others added 3 commits June 2, 2026 09:38
@mmfiuza mmfiuza marked this pull request as ready for review June 2, 2026 14:09
@mmfiuza
Copy link
Copy Markdown
Contributor Author

mmfiuza commented Jun 2, 2026

The changes seemed fine. I just added one more line of code to filter out non 64 bit platforms, since I know those will not work properly for this package.

@fingolfin fingolfin merged commit 3ead27a into JuliaPackaging:master Jun 3, 2026
15 checks passed
@mmfiuza
Copy link
Copy Markdown
Contributor Author

mmfiuza commented Jun 4, 2026

The merge of this JLL package to JuliaRegistries/General failed, as can be seen here:
JuliaRegistries/General#157003 (comment)

I understood what went wrong and now have the fix. My question is: how to send this new recipe? Do I just create another PR with the recipe change? Is there some other needed action to take? Do I have to leave a comment in the PR linked above to block the failed merge?

Notice: I had to change the CMakeLists.txt (and the source URL in the recipe) for the fix. So I guess it would be more correct to change numav_julia_jll to version 0.1.1 instead of 0.1.0+1, right?.

I'm also confused by the fact that the registration bot stated that the name numav_julia_jll does not follow the AutoMerge Guidelines because it contains the string "julia". Meanwhile, there are a lot of other valid JLL packages that contain "julia" in their names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants