[Torch] Fix deps issue for Torch

[rayegun]

Attempt to fix JuliaRegistries/General#68204

Might also need to be a BuildDependency in addition to Dependency

[stemann]

When this Torch JLL is registered (JuliaRegistries/General#68204), it might break current Torch.jl usages, as the C wrapper ("libtch") is not included - as there is no compat entry for Torch_jll in the currently registered Torch.jl.

[giordano]

@gbaraldi I suspect JuliaPackaging/BinaryBuilderBase.jl#271 broke something:

ERROR: LoadError: TypeError: in keyword argument platforms, expected Vector{<:AbstractPlatform}, got a value of type Vector{Any}
Stacktrace:
 [1] top-level scope
   @ /agent/_work/1/s/T/Torch/build_tarballs.jl:247
in expression starting at /agent/_work/1/s/T/Torch/build_tarballs.jl:247

[gbaraldi]

I will take a look.

Edit: It was that, it made it type unstable, so for empty arrays, which openblas_platforms is, it got Platforms[] but returned Any[]

[giordano]

When this Torch JLL is registered (JuliaRegistries/General#68204), it might break current Torch.jl usages, as the C wrapper ("libtch") is not included - as there is no compat entry for Torch_jll in the currently registered Torch.jl.

@stemann that should be fixed in the registry then (and in the package as well)

[giordano]

@Wimmerer maybe next time don't use "fix <PR in the General registry>", this closed JuliaRegistries/General#68204 😉

[rayegun]

Wait what, I figured that would have privileges preventing it.

Yeah sorry about this PR in general, I think I made it right before sleeping then forgot 🥲

[giordano]

JuliaRegistries/General#68946 sounds like protoc breaks the ABI across minor versions. What a mess