Skip to content

[Sundials] Upgrade to v6.7.0 #7974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024
Merged

[Sundials] Upgrade to v6.7.0 #7974

merged 1 commit into from
Jan 19, 2024

Conversation

staticfloat
Copy link
Member

@staticfloat staticfloat commented Jan 18, 2024

Also, require Julia v1.11+, since Julia v1.11 has a new SuiteSparse version. This will be the first version that supports Julia v1.11.

@staticfloat staticfloat requested a review from eschnett January 18, 2024 20:33
@imciner2 imciner2 changed the title [SuiteSparse] Upgrade to v6.7.0 [Sundials] Upgrade to v6.7.0 Jan 18, 2024
@ViralBShah
Copy link
Member

The real challenge is to upgrade the wrappers in Sundials.jl. My latest effort is in: SciML/Sundials.jl#415

Also, require Julia v1.11+
@staticfloat staticfloat force-pushed the sf/suitesparse_v6.7.0 branch from 6697ec5 to 713c693 Compare January 19, 2024 06:50
@staticfloat
Copy link
Member Author

Oh, I didn't realize that Sundials.jl does not yet work with Sundials v6+. Okay, this is less useful then.

@imciner2
Copy link
Member

We can still merge this and at least get the JLLs built so you can continue working on that. Is there anything else you need to do here, or is it ready to merge?

@ViralBShah ViralBShah merged commit 7ca1142 into master Jan 19, 2024
@ViralBShah ViralBShah deleted the sf/suitesparse_v6.7.0 branch January 19, 2024 13:23
grasph pushed a commit to Moelf/Yggdrasil that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants