Skip to content

BREAKING: Remove the LSF functionality from this package (and point users to JuliaParallel/LSFClusterManagers.jl instead) #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DilumAluthge merged 2 commits into from
Feb 3, 2025
Merged

BREAKING: Remove the LSF functionality from this package (and point users to JuliaParallel/LSFClusterManagers.jl instead) #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da08101
BREAKING: Remove the LSF functionality from this package (and point u…
DilumAluthge Feb 3, 2025
a67ed8a
Bump version from `0.4.9` to `1.0.0-DEV` (because this PR is a breaki…
DilumAluthge Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ClusterManagers"
uuid = "34f1f09b-3a8b-5176-ab39-66d58a4d544e"
version = "0.4.9"
version = "1.0.0-DEV"

[deps]
Distributed = "8ba89e20-285c-5b6f-9357-94700520ee1b"
Expand Down
7 changes: 1 addition & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ Implemented in this package (the `ClusterManagers.jl` package):

| Job queue system | Command to add processors |
| ---------------- | ------------------------- |
| Load Sharing Facility (LSF) | `addprocs_lsf(np::Integer; bsub_flags=``, ssh_cmd=``)` or `addprocs(LSFManager(np, bsub_flags, ssh_cmd, retry_delays, throttle))` |
| Sun Grid Engine (SGE) via `qsub` | `addprocs_sge(np::Integer; qsub_flags=``)` or `addprocs(SGEManager(np, qsub_flags))` |
| Sun Grid Engine (SGE) via `qrsh` | `addprocs_qrsh(np::Integer; qsub_flags=``)` or `addprocs(QRSHManager(np, qsub_flags))` |
| PBS (Portable Batch System) | `addprocs_pbs(np::Integer; qsub_flags=``)` or `addprocs(PBSManager(np, qsub_flags))` |
Expand All @@ -30,6 +29,7 @@ Implemented in external packages:

| Job queue system | Command to add processors |
| ---------------- | ------------------------- |
| Load Sharing Facility (LSF) via [LSFClusterManager.jl](https://github.com/JuliaParallel/LSFClusterManager.jl) | `addprocs_lsf(np::Integer; bsub_flags=``, ssh_cmd=``)` or `addprocs(LSFManager(np, bsub_flags, ssh_cmd, retry_delays, throttle))` |
| Kubernetes (K8s) via [K8sClusterManagers.jl](https://github.com/beacon-biosignals/K8sClusterManagers.jl) | `addprocs(K8sClusterManager(np; kwargs...))` |
| Azure scale-sets via [AzManagers.jl](https://github.com/ChevronETC/AzManagers.jl) | `addprocs(vmtemplate, n; kwargs...)` |

Expand Down Expand Up @@ -132,11 +132,6 @@ Julia workers can frequently timeout waiting for the standard output files to ap
In this case, it's better to use the `QRSHManager`, which uses SGE's `qrsh`
command to bypass the filesystem and captures STDOUT directly.

### Load Sharing Facility (LSF)

`LSFManager` supports IBM's scheduler. See the `addprocs_lsf` docstring
for more information.

### Using `LocalAffinityManager` (for pinning local workers to specific cores)

- Linux only feature.
Expand Down
1 change: 0 additions & 1 deletion src/ClusterManagers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,5 @@ include("condor.jl")
include("slurm.jl")
include("affinity.jl")
include("elastic.jl")
include("lsf.jl")

end
164 changes: 0 additions & 164 deletions src/lsf.jl
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions test/lsf.jl
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ using Test: @testset, @test, @test_skip
using ClusterManagers: ElasticManager
# Slurm:
using ClusterManagers: addprocs_slurm, SlurmManager
# LSF:
using ClusterManagers: addprocs_lsf, LSFManager
# SGE:
using ClusterManagers: addprocs_sge, SGEManager

Expand All @@ -23,7 +21,6 @@ const test_args = lowercase.(strip.(ARGS))
@info "" test_args

slurm_is_installed() = !isnothing(Sys.which("sbatch"))
lsf_is_installed() = !isnothing(Sys.which("bsub"))
qsub_is_installed() = !isnothing(Sys.which("qsub"))

@testset "ClusterManagers.jl" begin
Expand All @@ -42,19 +39,6 @@ qsub_is_installed() = !isnothing(Sys.which("qsub"))
end
end

if lsf_is_installed()
@info "Running the LSF tests..." Sys.which("bsub")
include("lsf.jl")
else
if "lsf" in test_args
@error "ERROR: The LSF tests were explicitly requested in ARGS, but bsub was not found, so the LSF tests cannot be run" Sys.which("bsub") test_args
@test false
else
@warn "bsub was not found - LSF tests will be skipped" Sys.which("bsub")
@test_skip false
end
end

if qsub_is_installed()
@info "Running the SGE (via qsub) tests..." Sys.which("qsub")
include("slurm.jl")
Expand Down
Loading