fix: preserve symbolic external units across precompile by MilesCranmerBot · Pull Request #215 · JuliaPhysics/DynamicQuantities.jl

MilesCranmerBot · 2026-04-22T15:57:29Z

Summary

Preserve external symbolic unit registrations across precompile and import boundaries.

Changes

thread the caller module through us"..." symbolic macro expansion
lazily re-register external bindings when a symbolic unit exists in the caller module but the symbolic registry has not been rebuilt yet
add a regression test covering the precompile/import case for external units

Testing

/usr/local/bin/julia --project -e 'using Pkg; Pkg.test()'

Fixes #212

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

github-actions · 2026-04-22T16:00:37Z

Benchmark Results (Julia v1.10)

Time benchmarks

	main	`9f886d9`...	main / `9f886d9`...
Quantity/creation/Quantity(x)	3.48 ± 0.001 ns	3.13 ± 0.01 ns	1.11 ± 0.0036
Quantity/creation/Quantity(x, length=y)	3.48 ± 0.01 ns	3.49 ± 0.01 ns	1 ± 0.0041
Quantity/with_numbers/*real	3.49 ± 0.01 ns	3.14 ± 0.01 ns	1.11 ± 0.0047
Quantity/with_numbers/^int	8.39 ± 2.4 ns	8.39 ± 2.4 ns	1 ± 0.41
Quantity/with_numbers/^int * real	8.39 ± 2.4 ns	8.39 ± 2.8 ns	1 ± 0.44
Quantity/with_quantity/+y	3.86 ± 0.04 ns	4.14 ± 0.069 ns	0.932 ± 0.018
Quantity/with_quantity//y	3.5 ± 0.01 ns	3.5 ± 0.009 ns	1 ± 0.0038
Quantity/with_self/dimension	3.48 ± 0.01 ns	3.13 ± 0.009 ns	1.11 ± 0.0045
Quantity/with_self/inv	3.48 ± 0.01 ns	3.48 ± 0.01 ns	1 ± 0.0041
Quantity/with_self/ustrip	3.48 ± 0.009 ns	4.17 ± 0.001 ns	0.837 ± 0.0022
QuantityArray/broadcasting/multi_array_of_quantities	0.148 ± 0.011 ms	0.148 ± 0.0025 ms	1 ± 0.075
QuantityArray/broadcasting/multi_normal_array	0.0561 ± 0.00031 ms	0.0594 ± 0.0035 ms	0.944 ± 0.055
QuantityArray/broadcasting/multi_quantity_array	0.173 ± 0.0028 ms	0.173 ± 0.0018 ms	1 ± 0.019
QuantityArray/broadcasting/x^2_array_of_quantities	26.6 ± 1.6 μs	26.6 ± 1.4 μs	1 ± 0.081
QuantityArray/broadcasting/x^2_normal_array	4.12 ± 0.41 μs	3.97 ± 0.4 μs	1.04 ± 0.15
QuantityArray/broadcasting/x^2_quantity_array	8.53 ± 0.34 μs	8.49 ± 0.32 μs	1 ± 0.055
QuantityArray/broadcasting/x^4_array_of_quantities	0.0877 ± 0.0016 ms	0.0884 ± 0.002 ms	0.993 ± 0.029
QuantityArray/broadcasting/x^4_normal_array	0.0561 ± 0.0031 ms	0.0526 ± 0.0032 ms	1.07 ± 0.087
QuantityArray/broadcasting/x^4_quantity_array	0.0597 ± 0.0035 ms	0.0561 ± 0.0035 ms	1.06 ± 0.091
time_to_load	0.211 ± 0.0015 s	0.209 ± 0.00069 s	1.01 ± 0.0078

Memory benchmarks

	main	`9f886d9`...	main / `9f886d9`...
Quantity/creation/Quantity(x)	0 allocs: 0 B	0 allocs: 0 B
Quantity/creation/Quantity(x, length=y)	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_numbers/*real	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_numbers/^int	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_numbers/^int * real	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_quantity/+y	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_quantity//y	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_self/dimension	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_self/inv	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_self/ustrip	0 allocs: 0 B	0 allocs: 0 B
QuantityArray/broadcasting/multi_array_of_quantities	2 allocs: 0.382 MB	2 allocs: 0.382 MB	1
QuantityArray/broadcasting/multi_normal_array	2 allocs: 0.0763 MB	2 allocs: 0.0763 MB	1
QuantityArray/broadcasting/multi_quantity_array	2 allocs: 0.0763 MB	2 allocs: 0.0763 MB	1
QuantityArray/broadcasting/x^2_array_of_quantities	2 allocs: 0.382 MB	2 allocs: 0.382 MB	1
QuantityArray/broadcasting/x^2_normal_array	2 allocs: 0.0763 MB	2 allocs: 0.0763 MB	1
QuantityArray/broadcasting/x^2_quantity_array	2 allocs: 0.0763 MB	2 allocs: 0.0763 MB	1
QuantityArray/broadcasting/x^4_array_of_quantities	2 allocs: 0.382 MB	2 allocs: 0.382 MB	1
QuantityArray/broadcasting/x^4_normal_array	2 allocs: 0.0763 MB	2 allocs: 0.0763 MB	1
QuantityArray/broadcasting/x^4_quantity_array	2 allocs: 0.0763 MB	2 allocs: 0.0763 MB	1
time_to_load	0.153 k allocs: 14.5 kB	0.153 k allocs: 14.5 kB	1

github-actions · 2026-04-22T16:01:48Z

Benchmark Results (Julia v1)

Time benchmarks

	main	`9f886d9`...	main / `9f886d9`...
Quantity/creation/Quantity(x)	2.44 ± 0.01 ns	2.44 ± 0.01 ns	1 ± 0.0058
Quantity/creation/Quantity(x, length=y)	2.71 ± 0.01 ns	2.71 ± 0.01 ns	1 ± 0.0052
Quantity/with_numbers/*real	2.7 ± 0.01 ns	2.71 ± 0.01 ns	0.996 ± 0.0052
Quantity/with_numbers/^int	10.3 ± 0.55 ns	10.3 ± 0.81 ns	1 ± 0.095
Quantity/with_numbers/^int * real	10.3 ± 0.82 ns	10.3 ± 0.82 ns	1 ± 0.11
Quantity/with_quantity/+y	3.21 ± 0.041 ns	3.31 ± 0.021 ns	0.97 ± 0.014
Quantity/with_quantity//y	2.71 ± 0 ns	2.71 ± 0 ns	1 ± 0
Quantity/with_self/dimension	2.44 ± 0.01 ns	2.71 ± 0.01 ns	0.9 ± 0.005
Quantity/with_self/inv	2.71 ± 0.01 ns	2.71 ± 0.01 ns	1 ± 0.0052
Quantity/with_self/ustrip	2.7 ± 0.01 ns	2.43 ± 0.009 ns	1.11 ± 0.0058
QuantityArray/broadcasting/multi_array_of_quantities	0.0881 ± 0.0035 ms	0.0882 ± 0.0027 ms	0.999 ± 0.05
QuantityArray/broadcasting/multi_normal_array	0.0435 ± 0.00019 ms	0.0408 ± 0.0002 ms	1.07 ± 0.007
QuantityArray/broadcasting/multi_quantity_array	0.041 ± 0.00023 ms	0.0437 ± 0.00025 ms	0.937 ± 0.0075
QuantityArray/broadcasting/x^2_array_of_quantities	23.4 ± 14 μs	22.9 ± 13 μs	1.02 ± 0.83
QuantityArray/broadcasting/x^2_normal_array	1.91 ± 1.5 μs	1.98 ± 1.4 μs	0.965 ± 1
QuantityArray/broadcasting/x^2_quantity_array	3.1 ± 2.4 μs	5.72 ± 0.55 μs	0.543 ± 0.43
QuantityArray/broadcasting/x^4_array_of_quantities	0.0696 ± 0.0031 ms	0.0687 ± 0.0037 ms	1.01 ± 0.071
QuantityArray/broadcasting/x^4_normal_array	0.0381 ± 0.00015 ms	0.0382 ± 0.00018 ms	0.999 ± 0.0062
QuantityArray/broadcasting/x^4_quantity_array	0.0383 ± 0.00018 ms	0.041 ± 0.00018 ms	0.934 ± 0.006
time_to_load	0.148 ± 0.0004 s	0.148 ± 0.0013 s	1 ± 0.0092

Memory benchmarks

	main	`9f886d9`...	main / `9f886d9`...
Quantity/creation/Quantity(x)	0 allocs: 0 B	0 allocs: 0 B
Quantity/creation/Quantity(x, length=y)	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_numbers/*real	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_numbers/^int	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_numbers/^int * real	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_quantity/+y	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_quantity//y	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_self/dimension	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_self/inv	0 allocs: 0 B	0 allocs: 0 B
Quantity/with_self/ustrip	0 allocs: 0 B	0 allocs: 0 B
QuantityArray/broadcasting/multi_array_of_quantities	3 allocs: 0.382 MB	3 allocs: 0.382 MB	1
QuantityArray/broadcasting/multi_normal_array	3 allocs: 0.0764 MB	3 allocs: 0.0764 MB	1
QuantityArray/broadcasting/multi_quantity_array	3 allocs: 0.0764 MB	3 allocs: 0.0764 MB	1
QuantityArray/broadcasting/x^2_array_of_quantities	3 allocs: 0.382 MB	3 allocs: 0.382 MB	1
QuantityArray/broadcasting/x^2_normal_array	3 allocs: 0.0764 MB	3 allocs: 0.0764 MB	1
QuantityArray/broadcasting/x^2_quantity_array	3 allocs: 0.0764 MB	3 allocs: 0.0764 MB	1
QuantityArray/broadcasting/x^4_array_of_quantities	3 allocs: 0.382 MB	3 allocs: 0.382 MB	1
QuantityArray/broadcasting/x^4_normal_array	3 allocs: 0.0764 MB	3 allocs: 0.0764 MB	1
QuantityArray/broadcasting/x^4_quantity_array	3 allocs: 0.0764 MB	3 allocs: 0.0764 MB	1
time_to_load	0.145 k allocs: 11 kB	0.145 k allocs: 11 kB	1

codecov · 2026-04-22T16:02:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.18%. Comparing base (c2098b5) to head (9f886d9).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   99.15%   99.18%   +0.02%     
==========================================
  Files          23       23              
  Lines        1305     1347      +42     
==========================================
+ Hits         1294     1336      +42     
  Misses         11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MilesCranmer · 2026-04-22T17:34:38Z

@MilesCranmerBot we need to get to 100% coverage of the diff please

MilesCranmer · 2026-04-22T18:12:49Z

@MilesCranmerBot code coverage is not yet 100% for the diff. And also see comment about making breaking changes please.

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

MilesCranmer · 2026-04-23T08:25:27Z

@MilesCranmerBot needs to add a test where we have a fake package that registers units, and that has a function which uses those units. See the recent issue for the workflow I'd like to enable.

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

MilesCranmerBot · 2026-04-23T08:45:34Z

Done. I pushed this to the PR branch in commit 7645686.

What changed:

replaced the bare module test with a fake package layout under test/precompile_test/ExternalUnitRegistration/src/ExternalUnitRegistration.jl
kept the registered external unit plus a function that uses us"MyWb" from inside that package
updated the regression to check the imported package entrypoints after precompilation/import

Validation:

/usr/local/bin/julia --project -e 'using Pkg; Pkg.test()'

MilesCranmer · 2026-04-23T09:03:46Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7645686b00

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

MilesCranmer · 2026-04-23T09:11:42Z

@MilesCranmerBot Please address the above feedback

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

MilesCranmerBot · 2026-04-23T09:22:43Z

Addressed the review feedback in 524cb15.

What changed:

restored the Constants. guard so module-local quantity bindings no longer shadow symbolic constants like c
made lazy external-unit registration use the existing unit-update lock, avoiding duplicate first-use registration races
added regression tests for both cases

Validation:

/usr/local/bin/julia --project=. -e 'using Pkg; Pkg.test(test_args=["unittests"])'

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

MilesCranmer · 2026-04-23T15:17:34Z

@codex review

chatgpt-codex-connector · 2026-04-23T15:27:40Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

MilesCranmer · 2026-04-23T17:01:00Z

Hm, I still think this feels too hacky... @MilesCranmerBot could you please change the PR in the following way? Here's a detailed description:

This can be fixed in a cleaner and more symmetric way.

The current PR appears to solve the immediate us"..." failure across precompile/import boundaries, but it does so by making only the symbolic parser caller-module-aware. That leaves u"..." and us"..." on different resolution paths:

u_str still expands through map_to_scope(Meta.parse(s))

us_str is changed to expand through map_to_scope(__module__, Meta.parse(s))

That asymmetry is hard to justify at the parser API level. External units should have one consistent resolution story, regardless of whether the target is ordinary or symbolic.

A cleaner fix would be:

Make both macros caller-module-aware.

Change @u_str in src/uparse.jl to call map_to_scope(__module__, Meta.parse(s))

Keep the same for @us_str

Add matching module-aware map_to_scope(mod::Module, ...) overloads on both the ordinary and symbolic sides.

map_to_scope(ex::Expr) = map_to_scope(@__MODULE__, ex)

map_to_scope(sym::Symbol) = map_to_scope(@__MODULE__, sym)

map_to_scope(mod::Module, ex::Expr) for recursive descent

map_to_scope(mod::Module, sym::Symbol) for symbol resolution

Share the external-binding detection and lazy registration logic instead of implementing it only for symbolic parsing.

The external binding check should live in shared internal code

The lazy registration path should also be shared

Both u"..." and us"..." should be able to recover an external unit from the caller module when the binding exists but the registration state has not yet been rebuilt in the current import/precompile lifecycle

Keep symbolic lookup independent of SYMBOLIC_UNIT_VALUES[i] cache alignment for correctness.

Reconstructing the symbolic quantity from the symbol is a reasonable approach

That part of the current PR looks directionally good

However, it should be part of a symmetric design rather than paired with a parser-only special case for us_str

Add regression tests for both ordinary and symbolic macros through an external module boundary.

u"MyExternalUnit"

us"MyExternalUnit"

direct use

imported helper function use

precompile/import style loading

threaded first-use if concurrency is relevant

The key point is that the problem does not appear to be that symbolic registration should stop being updated. The issue is that symbolic parsing currently has a more fragile lifecycle around external registrations, especially across precompile/import boundaries. The fix should therefore make the registration and recovery story more robust, but without introducing a macro-level asymmetry between u_str and us_str.

In short, the suggested direction is:

make u_str and us_str symmetric

share external-unit recovery logic

keep symbolic lookup robust to cache rebuild timing

test both macros the same way

That should produce a clearer and more maintainable design than fixing only us_str in isolation.

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

MilesCranmer · 2026-04-23T17:26:12Z

@MilesCranmerBot CI is failing, please fix.

MilesCranmer · 2026-04-23T18:40:50Z

@MilesCranmerBot code coverage of the diff is under 100%. Are there methods which aren't possible to hit in a realistic scenario? If so then please remove them. If it is possible to hit them, then ensure 100% diff coverage with testing.

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

MilesCranmerBot · 2026-04-23T19:02:31Z

Addressed this in a8912ae.

The uncovered diff lines were fallback branches in map_to_scope for u"..." / us"..." that looked reachable on paper, but they are not hit in the realistic external-unit flow this PR is fixing. I verified that trying to exercise them without a module binding still errors instead of going through that path, so I removed those dead branches rather than adding a contrived test.

I reran /usr/local/bin/julia --project=. -e 'import Pkg; Pkg.test(coverage=true)', and the full suite passed locally with the current diff lines covered.

MilesCranmer

@MilesCranmerBot see new comments

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

MilesCranmerBot · 2026-04-23T23:06:45Z

Addressed in 6efcab1.

What changed:

moved the external-unit registration helpers out of uparse.jl into shared internal code, so the parse paths stop reaching back into the parent module with reflective getfield(...) lookups
cleaned up the u"..." and us"..." symbol-resolution branches so the error conditions live together and the success path is the shared return block
kept builtin unit precedence over similarly named constants like h, while still preserving the external-unit recovery path across precompile/import boundaries

Validation:

/usr/local/bin/julia --project=. -e 'using Pkg; Pkg.test(test_args=["unittests"])'\n- /usr/local/bin/julia --project=. -e 'using Pkg; Pkg.test()'\n- /usr/local/bin/julia --project=. -e 'using Pkg; Pkg.test(coverage=true)'

MilesCranmer · 2026-04-24T21:27:18Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6efcab19a9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

MilesCranmer

@MilesCranmerBot Please address these comments + those of codex bot + ensure that code coverage for the diff is 100% (failing CI at the moment)

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

MilesCranmerBot · 2026-04-24T21:58:01Z

Addressed the open review comments in 9f886d9.

What changed:

removed the extra external_unit_lookup.jl helper file
restored uparse / sym_uparse support for registered units while keeping the external-unit precompile fix
simplified the parser branches and removed the GlobalRef(mod, sym) lookup pattern from the external-unit path
added explicit regression tests for registered-unit parsing so the changed lines are exercised directly

Local verification:

/usr/local/bin/julia --project=. -e 'using Pkg; Pkg.test()' ✅
focused external-unit smoke test for uparse / sym_uparse and precompile-style module lookup ✅

I also resolved the review threads that this commit addresses. CI is running on the updated branch now, including the codecov path.

MilesCranmer · 2026-04-25T03:06:07Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9f886d9c55

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-25T03:13:39Z

+    elseif has_external_binding
+        return Expr(:call, GlobalRef(@__MODULE__, :lookup_external_unit), QuoteNode(mod), QuoteNode(sym))


Avoid external fallback for registered unit symbols

When a caller module does using DynamicQuantities, built-in units like m satisfy both has_registered_binding and has_external_binding, so this branch routes u"..." through lookup_external_unit instead of lookup_unit. That forces ensure_registered_external_unit (and its global UNIT_UPDATE_LOCK) on every unit-literal evaluation, turning previously constant-like macro expansions into synchronized runtime lookups and degrading threaded hot paths. The external fallback should only run when the registered lookup is actually missing.

Useful? React with 👍 / 👎.

fix: preserve symbolic external units across precompile

4cf054a

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

MilesCranmerBot mentioned this pull request Apr 22, 2026

Proper way to support "g" (acceleration) unit #212

Open

MilesCranmer reviewed Apr 22, 2026

View reviewed changes

Comment thread test/precompile_test/ExternalUnitRegistration.jl Outdated

MilesCranmerBot and others added 2 commits April 22, 2026 18:32

test: cover SymbolicUnits wrapper entrypoints

37b3bd9

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

test: restore precompile coverage shape

45aa0f7

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

test: cover package-style external unit registration

7645686

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

chatgpt-codex-connector Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread src/symbolic_dimensions.jl Outdated

Comment thread src/symbolic_dimensions.jl Outdated

fix: address symbolic unit review feedback

524cb15

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

MilesCranmer reviewed Apr 23, 2026

View reviewed changes

Comment thread src/symbolic_dimensions.jl Outdated

style: simplify symbolic unit lookup branches

dde2975

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

MilesCranmer reviewed Apr 23, 2026

View reviewed changes

Comment thread src/symbolic_dimensions.jl Outdated

MilesCranmerBot and others added 2 commits April 23, 2026 13:42

refactor: simplify symbolic unit registration lookup

982937d

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

fix: simplify symbolic external unit lookup

b06c809

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

fix: make external unit parsing symmetric

39abd36

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

fix: handle external unit lookup in precompile

97a2983

fix: remove unreachable unit lookup fallbacks

a8912ae

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

MilesCranmer reviewed Apr 23, 2026

View reviewed changes

Comment thread src/symbolic_dimensions.jl Outdated

MilesCranmer requested changes Apr 23, 2026

View reviewed changes

Comment thread src/symbolic_dimensions.jl Outdated

Comment thread src/uparse.jl Outdated

Comment thread src/uparse.jl Outdated

Comment thread src/uparse.jl Outdated

MilesCranmerBot and others added 2 commits April 23, 2026 22:48

refactor: centralize builtin unit symbol snapshot

c5c1868

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

refactor: clean up external unit lookup

6efcab1

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

chatgpt-codex-connector Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread src/uparse.jl Outdated

Comment thread src/symbolic_dimensions.jl Outdated

MilesCranmer requested changes Apr 24, 2026

View reviewed changes

Comment thread src/external_unit_lookup.jl Outdated

Comment thread src/uparse.jl Outdated

Comment thread src/uparse.jl Outdated

Comment thread src/symbolic_dimensions.jl Outdated

Comment thread src/symbolic_dimensions.jl

fix: restore registered unit parsing paths

9f886d9

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>

chatgpt-codex-connector Bot reviewed Apr 25, 2026

View reviewed changes

		elseif has_external_binding
		return Expr(:call, GlobalRef(@__MODULE__, :lookup_external_unit), QuoteNode(mod), QuoteNode(sym))

Conversation

MilesCranmerBot commented Apr 22, 2026

Summary

Changes

Testing

Uh oh!

github-actions Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark Results (Julia v1.10)

Uh oh!

github-actions Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark Results (Julia v1)

Uh oh!

codecov Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MilesCranmer commented Apr 22, 2026

Uh oh!

Uh oh!

MilesCranmer commented Apr 22, 2026

Uh oh!

MilesCranmer commented Apr 23, 2026

Uh oh!

MilesCranmerBot commented Apr 23, 2026

Uh oh!

MilesCranmer commented Apr 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

MilesCranmer commented Apr 23, 2026

Uh oh!

MilesCranmerBot commented Apr 23, 2026

Uh oh!

Uh oh!

Uh oh!

MilesCranmer commented Apr 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 23, 2026

Uh oh!

MilesCranmer commented Apr 23, 2026

Uh oh!

MilesCranmer commented Apr 23, 2026

Uh oh!

MilesCranmer commented Apr 23, 2026

Uh oh!

MilesCranmerBot commented Apr 23, 2026

Uh oh!

Uh oh!

MilesCranmer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MilesCranmerBot commented Apr 23, 2026

Uh oh!

MilesCranmer commented Apr 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

MilesCranmer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MilesCranmerBot commented Apr 24, 2026

github-actions Bot commented Apr 22, 2026 •

edited

Loading

github-actions Bot commented Apr 22, 2026 •

edited

Loading

codecov Bot commented Apr 22, 2026 •

edited

Loading