Skip to content

Conversation

@hervasa2
Copy link
Collaborator

@hervasa2 hervasa2 commented Oct 28, 2025

Unsupported operations (since #489) with CartesianPoint's were used in move_charges_inside_semiconductor causing errors when drifting charges (see #552)

I switched them to vectors by using point -> point - cartesian_zero.
This PR fixes these issues and correctly passes verbose when using move_charges_inside_semiconductor

simulate_waveforms( mcevents_table::AbstractVector{<:NamedTuple}, sim::Simulation{T}

@fhagemann
Copy link
Collaborator

Can we add a test for this, to make sure that things like this are also tested in the future and covered by the tests?
(Just put a very large charge cloud very close to a surface in any of the tests, maybe the diffusion tests?)

@fhagemann fhagemann added this to the v0.11.0 milestone Oct 29, 2025
@fhagemann
Copy link
Collaborator

Downgrade tests failed because the current method of computing a weighted mean of CartesianPoints requires a change introduced in [email protected] --> JuliaStats/StatsBase.jl@9916e14

@hervasa2
Copy link
Collaborator Author

Thanks for adding the tests. I think this is good to go.

@fhagemann fhagemann merged commit ff18bf6 into JuliaPhysics:main Oct 29, 2025
10 checks passed
@fhagemann fhagemann added bug Something isn't working dependencies Pull requests that update a dependency file labels Oct 29, 2025
@fhagemann fhagemann linked an issue Nov 20, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Operations with CartesianPoints not supported and causing errors

2 participants