Use vectors instead of points to move_charges_inside_semiconductor
#553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsupported operations (since #489) with
CartesianPoint's were used inmove_charges_inside_semiconductorcausing errors when drifting charges (see #552)I switched them to vectors by using
point->point - cartesian_zero.This PR fixes these issues and correctly passes
verbosewhen usingmove_charges_inside_semiconductor