-
Notifications
You must be signed in to change notification settings - Fork 50
Adjust default min_tick_distance based on the grid dimensions
#572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
That looks very nice! I can have a closer look later today. |
|
Thank you ! Is there anything else to add/change in this PR ? |
|
I think this should be good. |
|
Nice, is this what's discussed in issue #530 or something separate ? |
|
It’s not an issue yet, and I don‘t think we need to change anything, but just like a minimum tick distance, there is also a maximum tick distance. I just want to cross-check that, after changing the minimum tick distance, we are not messing anything up by not adjusting the maximum tick distance (default). |
min_tick_distance based on the grid dimensions
* Add function compute_min_tick_distance * Add test * Add yaml file for test * Changes in compute_min_tick_distance and tests * Simulation changes and test * Shorten test code * Minor code style changes --------- Co-authored-by: Felix Hagemann <[email protected]>


This PR introduces a new function


compute_min_tick_distanceas a possible solution to replace the previous hard-codedmin_tick_distancein simulation. The new function computes a minimum grid spacing for both Cartesian and Cylindrical grids, taking into account the grid dimensions.This function provides a finer default grid for detectors of O(100µm) size. The example introduced (BEGe_03.yaml) shows the default grid spacing provided by the simulation with the previous hard-coded method using a small detector:
and using the new function: