Refactor ThermalDiffusionLithiumDensity to remove hardcoded parameters

[SimonePellegrini]

This PR addresses #567

[SimonePellegrini]

I tried to understand where the error comes from, but it does not seem to be related to the changes I made.

[fhagemann]

I tried to understand where the error comes from, but it does not seem to be related to the changes I made.

The error in the documentation build came from adding the unregistered package LegendHDF5IO to Project.toml, the other errors came from the fact that we were storing H in units of eV, but expecting it in units of cal in the subsequent formulas. This should (hopefully) all be fixed now.

[fhagemann]

Ok, the lithium_density_on_contact also seems to be underestimated by 6 orders of magnitude (it's probably in cm^-3 instead of m^-3)

[zpdg]

@fhagemann @SimonePellegrini
Good job! Thanks!

To be clear, why I wrote 27.27 instead of 21.27 as the ref?: Because the default length unit is "m" in SSD.jl, but people prefer to use "cm" and "cm^3" when talking about impurity density.

[fhagemann]

Yes, I figured that out after looking at the numbers :)
Thanks for the clarification

[fhagemann]

Hi, could you undo pushing the example JSON file for the inverted coaxial detectors? :)

[SimonePellegrini]

Hi, could you undo pushing the example JSON file for the inverted coaxial detectors? :)

I think I've done it :)

[fhagemann]

There are some minor things to clean up, but I can take care of that!

[fhagemann]

I moved all the structs and functions for diffusivity and saturation to the new file ThermalDiffusionLithiumDensityParameters.jl, added doc strings and removed obsolete code.

I also removed the suffx _in_germanium from the methods calculating the diffusivity, because the references also allow to do the same thing in silicon (no need to restrict the naming here).

We could add tests to trigger all the ConfigErrors (what happens if the list is empty, if it's missing parameters, ...), but other than that, this should be good to go.

[fhagemann]

I think this should be it!
@zpdg If you're ok with renaming llthium_diffusivity_in_germanium to just lithium_diffusivity, this should be good ton be merged!

And thanks @SimonePellegrini for getting this started!

[SimonePellegrini]

I think this should be it! @zpdg If you're ok with renaming llthium_diffusivity_in_germanium to just lithium_diffusivity, this should be good ton be merged!

And thanks @SimonePellegrini for getting this started!

It was a pleasure helping you! I learned a lot of interesting things. I'm looking forward to getting better and being more helpful to the Julia ecosystem :)

[zpdg]

I think this should be it! @zpdg If you're ok with renaming llthium_diffusivity_in_germanium to just lithium_diffusivity, this should be good ton be merged!

And thanks @SimonePellegrini for getting this started!

This restriction is unnecessary. I am okay with it.