Skip to content

Fix missing * MixedUnits throwing MethodError#839

Merged
giordano merged 1 commit intoJuliaPhysics:masterfrom
aplavin:fix-missing-mixedunits
Mar 15, 2026
Merged

Fix missing * MixedUnits throwing MethodError#839
giordano merged 1 commit intoJuliaPhysics:masterfrom
aplavin:fix-missing-mixedunits

Conversation

@aplavin
Copy link
Copy Markdown
Contributor

@aplavin aplavin commented Mar 1, 2026

Summary

  • missing * u"dB" (and other MixedUnits operations with missing) threw a MethodError because the existing Missing methods only covered Units, not MixedUnits
  • Add * and / methods for Missing with MixedUnits, mirroring the existing Units methods

Test plan

  • Added tests for missing * u"dB", u"dB" * missing, missing / u"dB", u"dB" / missing
  • Full test suite passes

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@51f55a1). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #839   +/-   ##
=========================================
  Coverage          ?   90.04%           
=========================================
  Files             ?       22           
  Lines             ?     1707           
  Branches          ?        0           
=========================================
  Hits              ?     1537           
  Misses            ?      170           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aplavin
Copy link
Copy Markdown
Contributor Author

aplavin commented Mar 15, 2026

gentle bump

@giordano giordano merged commit 8ad36fe into JuliaPhysics:master Mar 15, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants