Use the same plotlyjs version number for all imports#480
Merged
BeastyBlacksmith merged 2 commits intoJuliaPlots:masterfrom Jan 15, 2024
Merged
Use the same plotlyjs version number for all imports#480BeastyBlacksmith merged 2 commits intoJuliaPlots:masterfrom
BeastyBlacksmith merged 2 commits intoJuliaPlots:masterfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #480 +/- ##
==========================================
- Coverage 37.50% 36.51% -0.99%
==========================================
Files 4 4
Lines 288 293 +5
==========================================
- Hits 108 107 -1
- Misses 180 186 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Thanks! Could you also make a release? Then we can work on JuliaPlots/Plots.jl#4862 |
Contributor
Author
|
Thanks again :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure that the same version of the plotlyjs web asset is used for all imports: through artifact or through CDN.
This also adds
_js_versionand_js_pathas public API: this means other packages can depend on PlotlyJS.jl to get the plotly.min.js asset. Used in JuliaPlots/Plots.jl#4862