interpolate scratch_dir to avoid precompilation failure in 1.12#5072
Merged
BeastyBlacksmith merged 3 commits intoJuliaPlots:masterfrom Apr 17, 2025
Merged
interpolate scratch_dir to avoid precompilation failure in 1.12#5072BeastyBlacksmith merged 3 commits intoJuliaPlots:masterfrom
BeastyBlacksmith merged 3 commits intoJuliaPlots:masterfrom
Conversation
Contributor
Author
|
I think it would be nice, if this is a good solution, to make a 1.40.13 release with this as soon as possible, because otherwise CI runs will fail for all packages in Julia 1.12 pre-releases that depend on Plots.jl (on extensions, for example). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5072 +/- ##
==========================================
- Coverage 89.77% 89.38% -0.39%
==========================================
Files 40 40
Lines 8780 8452 -328
==========================================
- Hits 7882 7555 -327
+ Misses 898 897 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KristofferC
approved these changes
Apr 16, 2025
Member
|
Thanks! Would be nice, if you also could port that to the v2 branch. |
lmiq
added a commit
to lmiq/Plots.jl
that referenced
this pull request
Apr 17, 2025
BeastyBlacksmith
pushed a commit
that referenced
this pull request
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Interpolating the
scratch_dirvariable in the precompilation directive solves the precompilation failure observed in v1.12-beta1.Attribution
Things to consider