Skip to content

use runic formatter#5132

Merged
t-bltg merged 19 commits intoJuliaPlots:v2from
t-bltg:formatter
Jul 3, 2025
Merged

use runic formatter#5132
t-bltg merged 19 commits intoJuliaPlots:v2from
t-bltg:formatter

Conversation

@t-bltg
Copy link
Member

@t-bltg t-bltg commented Jul 3, 2025

No description provided.

@t-bltg t-bltg added the formatting code style label Jul 3, 2025
@t-bltg t-bltg force-pushed the formatter branch 9 times, most recently from ffd67fb to 4912a5f Compare July 3, 2025 10:25
@t-bltg t-bltg merged commit 004d48d into JuliaPlots:v2 Jul 3, 2025
12 checks passed
@t-bltg t-bltg deleted the formatter branch July 3, 2025 11:19
@BeastyBlacksmith
Copy link
Member

What was wrong with the old formatter?

Also please give people a few days to react before merging things like this.

@t-bltg
Copy link
Member Author

t-bltg commented Jul 3, 2025

What was wrong with the old formatter?

Runic is more consistent with julia standard for beginners.

Also please give people a few days to react before merging things like this.

I'm fixing all the things here, for example master was completely broken since 1.40.13for the docs.

Since literally no one is contributing to Plots these days, and since it is a bit of a nightmare to maintain master and v2, I won't accept spending time waiting for reviews.

Of course anyone interested to chime in is welcome.

@t-bltg
Copy link
Member Author

t-bltg commented Jul 3, 2025

Also, #5098 was merged too soon, bc no one built the docs, so I had to fix those.

@t-bltg
Copy link
Member Author

t-bltg commented Jul 3, 2025

bc no one built the docs, so I had to fix those

For that purpose, I've added an extra condition for the docs.yml github action : one can request to build the docs in a PR if one applies the labels documentation to the PR. This way, we can check when a PR is ready for review if it breaks the docs or not.

@BeastyBlacksmith
Copy link
Member

Don't get me wrong, I see you are doing a lot of work and I appreciate that. Still, this is collaborative project and pushing decisions without giving other people time to react and no rationale for the decision is kind of rude.

Again, you are doing great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants