make Plots relocatable again #5200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
force-pushed
the
kc/relocatable
branch
from
88f0d61 to
ba4338d
Compare
Co-authored-by: Simon Christ <[email protected]>
Contributor
Author
|
I have no idea what the state of CI is on this repo. Are the test failures something I should look into or are they expected etc? |
Member
|
I am trying to figure that out too.. I think they are unrelated to this PR. The GraphRecipes failures are due to a recent update in GR and PyCall failing to precompile is definitely new, but also unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@pathcommand needs to execute during precompilation for RelocatableFolders to work. This was changed in a1ad4c9#diff-4bd462497f5ac8631d218b72f21cf9d5f383e7a1500f0fee0b8cb776b9a4dac4.