Skip to content

Improve ANSI white / light white output - #3595

Merged
Pangoraw merged 1 commit into
JuliaPluto:mainfrom
penelopeysm:main
Aug 31, 2026
Merged

Pangoraw merged 1 commit into
JuliaPluto:mainfrom
penelopeysm:main

Conversation

@penelopeysm

@penelopeysm penelopeysm commented Jul 10, 2026 •

Copy link
Copy Markdown
Contributor

Closes #3593

Screenshots in light/dark mode:

Screenshot 2026-07-10 at 14 06 54 Screenshot 2026-07-10 at 14 07 09

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/penelopeysm/Pluto.jl", rev="main")
julia> using Pluto

Comment thread frontend/ansi-colors.css
--ansi-red: rgb(220, 0, 0);
--ansi-magenta: rgb(200, 0, 200);
--ansi-white: rgb(220, 220, 220);
--ansi-bright-black: rgb(50, 50, 50);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was being shadowed by the line below

@Pangoraw

Copy link
Copy Markdown
Member

Thanks!

@Pangoraw
Pangoraw merged commit 64dfcd7 into JuliaPluto:main Aug 31, 2026
5 of 6 checks passed
@fonsp

fonsp commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Thank you, your changes are nice!

There are still some contrast issues in the other colors. Notably, the colors should be inverted in "light mode". ie in light mode, "White" should actually be black. I think the idea is that terminal color code is designed for a white-text-on-black-background terminal, and in light mode, you just invert everything.

Here is a screenshot from the MacOS terminal to show how to handle this properly:

Scherm颅afbeelding 2026-10-06 om 14 16 21 Scherm颅afbeelding 2026-10-06 om 14 16 38

EDIT: wait the MacOS app is not showing what I mean.

@fonsp

fonsp commented Oct 6, 2026

Copy link
Copy Markdown
Member

Moved to #3623

@penelopeysm

Copy link
Copy Markdown
Contributor Author

There are still some contrast issues

I'm aware, that's why I opened #3596 :)

@fonsp

fonsp commented Oct 8, 2026

Copy link
Copy Markdown
Member

Ahh right! I thought I remembered it but I forgot you made a separate issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

:white and :light_white output can't be read

3 participants