Repository navigation
Terminal ANSI colors contrast #3623
Description
Activity
Hi! I would love to work on this issue. Could you please assign it to me?
Reacted by Παναγιώτης ΓεωργακόπουλοςHi @abhijeetnardele24-hash ! Feel free to take a look and open a draft PR! I won't use the "assign" feature but feel free to work on it.
Reacted by Παναγιώτης ΓεωργακόπουλοςHey @abhijeetnardele24-hash ! Thanks for taking an interest! Your PR looks AI generated, but we can also AI-generate PRs ourselves.
We are not interested so much in code, but in YOU! What do YOU think about this issue? What would you change? Why?
Follow-up from #3595
There are still some contrast issues in the terminal ANSI colors. I think that the colors should be inverted in "light mode". ie in light mode, "White" should actually be black.
I think the idea is that terminal color code is designed for a white-text-on-black-background terminal, and in light mode, you just invert everything.Not sure if this is true...Here is a screenshot from the MacOS terminal with bad contrast:
And the VS Code terminal has good contrast:
For this issue, it's good to figure out how exactly this works. What's the expectation from people who write terminal color code?