Add support for new JSON 1.0 release#262
Conversation
|
I think the failures here are unrelated? Something about checking pip interop? |
|
It would be great to get this in. We converted our packages to JSON 1.0 (it unfortunately was not possible to allow 0.21 at the same time), and now we are unable to use the dev version of the package inside Jupyter notebooks. @ViralBShah @stevengj, from the commit history, it looks as if you two are mostly maintaining this. Would it be possible if one of you has a look at this? Thanks! |
|
just filed a PR in IJulia JuliaLang/IJulia.jl#1197 that works with JSON v1 as soon as Conda's json compat is bumped to include 1 |
|
Maybe @ViralBShah or @stevengj could help take a look here? I think the JSON usage/changes here are pretty minor/easy, but it seems like something else is goign wrong w/ the tests. If no one else can take a look, I can try to dig in since this package is blocking a lot of others from upgrading to JSON 1.0. |
|
I am happy to take a look but my work here has mainly been CI maintenance. |
|
The API in Conda.jl needs to be updated: I think it should be ok to mark the test as broken and open a new issue, in order to unblock this. Filed #265 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
=======================================
Coverage 85.22% 85.22%
=======================================
Files 1 1
Lines 203 203
=======================================
Hits 173 173
Misses 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #264