Skip to content

Add support for new JSON 1.0 release#262

Merged
ViralBShah merged 2 commits into
JuliaPy:masterfrom
quinnj:jq-json-1.0
Oct 20, 2025
Merged

Add support for new JSON 1.0 release#262
ViralBShah merged 2 commits into
JuliaPy:masterfrom
quinnj:jq-json-1.0

Conversation

@quinnj

@quinnj quinnj commented Oct 3, 2025

Copy link
Copy Markdown
Contributor

Fixes #264

@quinnj

quinnj commented Oct 3, 2025

Copy link
Copy Markdown
Contributor Author

I think the failures here are unrelated? Something about checking pip interop?

@lgoettgens

Copy link
Copy Markdown

It would be great to get this in. We converted our packages to JSON 1.0 (it unfortunately was not possible to allow 0.21 at the same time), and now we are unable to use the dev version of the package inside Jupyter notebooks.

@ViralBShah @stevengj, from the commit history, it looks as if you two are mostly maintaining this. Would it be possible if one of you has a look at this? Thanks!

@hhaensel

Copy link
Copy Markdown

just filed a PR in IJulia JuliaLang/IJulia.jl#1197 that works with JSON v1 as soon as Conda's json compat is bumped to include 1

@quinnj

quinnj commented Oct 18, 2025

Copy link
Copy Markdown
Contributor Author

Maybe @ViralBShah or @stevengj could help take a look here? I think the JSON usage/changes here are pretty minor/easy, but it seems like something else is goign wrong w/ the tests. If no one else can take a look, I can try to dig in since this package is blocking a lot of others from upgrading to JSON 1.0.

@ViralBShah

Copy link
Copy Markdown
Collaborator

I am happy to take a look but my work here has mainly been CI maintenance.

@ViralBShah

ViralBShah commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator

The API in Conda.jl needs to be updated:

[ Info: Running `conda config --set pip_interop_enabled true --file /Users/viral/.julia/conda/3/aarch64/envs/test_conda_jl/condarc-julia.yml` in test_conda_jl environment
WARNING conda.cli.main_config:_set_key(451): Key pip_interop_enabled is an alias of prefix_data_interoperability; setting value with latter
Conda.pip_interop: Test Failed at /Users/viral/.julia/dev/Conda/test/runtests.jl:138
  Expression: Conda.pip_interop(env)

I think it should be ok to mark the test as broken and open a new issue, in order to unblock this.

Filed #265

@codecov-commenter

codecov-commenter commented Oct 20, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.22%. Comparing base (d2c5831) to head (28800db).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files           1        1           
  Lines         203      203           
=======================================
  Hits          173      173           
  Misses         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah ViralBShah merged commit 4d4fd42 into JuliaPy:master Oct 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON is restricted to version 0.21

6 participants