-
-
Notifications
You must be signed in to change notification settings - Fork 108
Add SARS tdlearning back to lib #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1050 +/- ##
==========================================
+ Coverage 55.68% 57.50% +1.82%
==========================================
Files 69 71 +2
Lines 2726 2751 +25
==========================================
+ Hits 1518 1582 +64
+ Misses 1208 1169 -39
|
src/ReinforcementLearningCore/src/policies/explorers/epsilon_greedy_explorer.jl
Outdated
Show resolved
Hide resolved
src/ReinforcementLearningFarm/src/algorithms/tabular/td_learner.jl
Outdated
Show resolved
Hide resolved
src/ReinforcementLearningFarm/src/algorithms/tabular/td_learner.jl
Outdated
Show resolved
Hide resolved
src/ReinforcementLearningFarm/src/algorithms/tabular/td_learner.jl
Outdated
Show resolved
Hide resolved
src/ReinforcementLearningFarm/src/algorithms/tabular/td_learner.jl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good idea naming the FluxApproximator. One day this could be moving to a Flux extension.
TabularApproximator
, too many unforced errors with it specifiedApproximator
becomesFluxModelApproximator
for clarityTabularApproximator
andFluxModelApproximator
are independent subtypes ofAbstractLearner
PR Checklist