Skip to content

Add TotalRewardPerEpisodeLastN hook #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 21, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ReinforcementLearningFarm/src/hooks/hooks.jl
Original file line number Diff line number Diff line change
@@ -1 +1 @@
include("total_reward_per_episode_last_n.jl")
include("total_reward_per_last_n_episodes.jl")
Original file line number Diff line number Diff line change
Expand Up @@ -5,47 +5,41 @@
using CircularArrayBuffers: CircularVectorBuffer

"""
TotalRewardPerEpisodeLastN{F}(; max_steps = 100)
TotalRewardPerLastNEpisodes{F}(; max_episodes = 100)

A hook that keeps track of the total reward per episode for the last `max_steps` episodes.
"""
struct TotalRewardPerEpisodeLastN{F} <: AbstractHook where {F<:AbstractFloat}
struct TotalRewardPerLastNEpisodes{F} <: AbstractHook where {F<:AbstractFloat}
rewards::CircularVectorBuffer{F}

function TotalRewardPerEpisodeLastN(; max_steps = 100)
function TotalRewardPerLastNEpisodes(; max_steps = 100)
new{Float64}(CircularVectorBuffer{Float64}(max_steps))
end
end

Base.getindex(h::TotalRewardPerEpisodeLastN{F}, inds...) where {F<:AbstractFloat} =
Base.getindex(h::TotalRewardPerLastNEpisodes{F}, inds...) where {F<:AbstractFloat} =

Check warning on line 20 in src/ReinforcementLearningFarm/src/hooks/total_reward_per_last_n_episodes.jl

View check run for this annotation

Codecov / codecov/patch

src/ReinforcementLearningFarm/src/hooks/total_reward_per_last_n_episodes.jl#L20

Added line #L20 was not covered by tests
getindex(h.rewards, inds...)

Base.push!(
h::TotalRewardPerEpisodeLastN{F},
h::TotalRewardPerLastNEpisodes{F},
::PostActStage,
agent::P,
env::E,
player::Symbol,
) where {P<:AbstractPolicy,E<:AbstractEnv,F<:AbstractFloat} =
h.rewards[end] += reward(env, player)

function Base.push!(
hook::TotalRewardPerEpisodeLastN{F},
Base.push!(
hook::TotalRewardPerLastNEpisodes{F},
::PreEpisodeStage,
agent,
env,
) where {F<:AbstractFloat}
Base.push!(hook.rewards, 0.0)
return
end
) where {F<:AbstractFloat} = Base.push!(hook.rewards, 0.0)

function Base.push!(
hook::TotalRewardPerEpisodeLastN{F},
Base.push!(
hook::TotalRewardPerLastNEpisodes{F},
stage::Union{PreEpisodeStage,PostEpisodeStage,PostExperimentStage},
agent,
env,
player::Symbol,
) where {F<:AbstractFloat}
Base.push!(hook, stage, agent, env)
return
end
) where {F<:AbstractFloat} = Base.push!(hook, stage, agent, env)
2 changes: 1 addition & 1 deletion src/ReinforcementLearningFarm/test/hooks/hooks.jl
Original file line number Diff line number Diff line change
@@ -1 +1 @@
include("total_reward_per_episode_last_n.jl")
include("total_reward_per_last_n_episodes.jl")
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
using ReinforcementLearningFarm: TotalRewardPerEpisodeLastN
using ReinforcementLearningFarm: TotalRewardPerLastNEpisodes

@testset "TotalRewardPerEpisodeLastN" begin
@testset "TotalRewardPerLastNEpisodes" begin
@testset "Single Agent" begin
hook = TotalRewardPerEpisodeLastN(max_steps = 10)
hook = TotalRewardPerLastNEpisodes(max_steps = 10)
env = TicTacToeEnv()
agent = RandomPolicy()

Expand All @@ -15,7 +15,7 @@ using ReinforcementLearningFarm: TotalRewardPerEpisodeLastN
end

@testset "MultiAgent" begin
hook = TotalRewardPerEpisodeLastN(max_steps = 10)
hook = TotalRewardPerLastNEpisodes(max_steps = 10)
env = TicTacToeEnv()
agent = RandomPolicy()

Expand Down
Loading