Skip to content

Fix abstract_learner for multiplayer games #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 22, 2024
Merged

Conversation

jeremiahpslewis
Copy link
Member

@jeremiahpslewis jeremiahpslewis commented Mar 21, 2024

This pull request fixes the abstract_learner for multiplayer games. It adds a new function forward(learner::L, env::E, player::Symbol) that takes a learner, environment, and player symbol as arguments and sends the state to RLCore.forward(Learner, State). This ensures that the learner can handle multiplayer games correctly.

It also cleans up a few other minor issues along the way.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 59.32%. Comparing base (93a13d3) to head (d6d9813).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
- Coverage   59.34%   59.32%   -0.03%     
==========================================
  Files          73       73              
  Lines        2789     2795       +6     
==========================================
+ Hits         1655     1658       +3     
- Misses       1134     1137       +3     
Files Coverage Δ
...nforcementLearningCore/src/core/stop_conditions.jl 80.64% <100.00%> (ø)
...ntLearningCore/src/policies/learners/td_learner.jl 91.30% <ø> (ø)
...ningCore/src/policies/learners/abstract_learner.jl 61.53% <50.00%> (+1.53%) ⬆️
...rcementLearningCore/src/policies/q_based_policy.jl 60.00% <50.00%> (-11.43%) ⬇️

@jeremiahpslewis jeremiahpslewis merged commit f8d5eb7 into main Mar 22, 2024
22 checks passed
@jeremiahpslewis jeremiahpslewis deleted the jpsl/learner-fix branch March 22, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants