Fix NStepBatchSampler sampling out of bounds indicies#74
Open
ludvigk wants to merge 3 commits intoJuliaReinforcementLearning:mainfrom
Open
Fix NStepBatchSampler sampling out of bounds indicies#74ludvigk wants to merge 3 commits intoJuliaReinforcementLearning:mainfrom
ludvigk wants to merge 3 commits intoJuliaReinforcementLearning:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage 74.23% 74.23%
=======================================
Files 18 18
Lines 850 850
=======================================
Hits 631 631
Misses 219 219 ☔ View full report in Codecov by Sentry. |
Member
|
@ludvigk Thanks! Can you please add a test that confirms the fix works? |
Author
|
When updating the test it seemed to me as if the episode buffer has a size of capacity + 2. After pushing 12 or more states to the buffer with capacity 10, valid_range returns an array with 12 elements instead of 11. I'm not 100% sure where the extra +1 comes from though. Clearly I broke something else, so my "fix" was not correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When stacksize > 1, NStepBatchSampler samples inds < stacksize, which causes out of bounds errors.