Added more functionality for NodalData #114
Open
stepholinger wants to merge 2 commits intoJuliaSeismo:masterfrom
Open
Added more functionality for NodalData #114stepholinger wants to merge 2 commits intoJuliaSeismo:masterfrom
stepholinger wants to merge 2 commits intoJuliaSeismo:masterfrom
Conversation
…g, fft/ifft, additional types)
Collaborator
|
This is awesome! I'm going to transfer SeisNoise to the SeismoJulia org shortly. How about we work on this PR after we transfer over there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes new types and functions for handling manipulation of NodalData. The content of this update should all work and be useful, though there are already a few ways I can think of to improve some aspects of the code (i.e. there is some unnecessary-feeling metadata that gets passed through the NodalProcessedData type that is inconvenient in some cases). Happy to meet to chat about any of this stuff!
Future updates will include FK filtering and batch correlation tools, though we should probably chat about reconciling some of that with the existing nodalcorrelation functions. I have a few other helpful functions I didn't include this time as I'd like to go through them in a bit more detail.