Conversation
devmotion
force-pushed
the
dw/logupdf
branch
2 times, most recently
from
c740751 to
0a2d5c9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 70.88% 74.39% +3.51%
==========================================
Files 17 22 +5
Lines 838 949 +111
==========================================
+ Hits 594 706 +112
+ Misses 244 243 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
devmotion
force-pushed
the
dw/logupdf
branch
2 times, most recently
from
1f8060d to
3e61731
Compare
Contributor
|
@devmotion I just noticed you got started on this. Anything I can do to help it along? |
devmotion
force-pushed
the
dw/logupdf
branch
2 times, most recently
from
2dd01ad to
827b221
Compare
Member
Author
|
I had actually forgotten the PR, probably also since nobody reacted to it. I fixed the merge conflicts and applied a few fixes, so tests pass now. |
sethaxen
suggested changes
Mar 12, 2026
Contributor
sethaxen
left a comment
sethaxen
left a comment
There was a problem hiding this comment.
The math/code all looks correct. Just some minor suggestions.
Co-authored-by: Seth Axen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #185.