Conversation
| name = "StatsFuns" | ||
| uuid = "4c63d2b9-4356-54db-8cca-17b64c39e42c" | ||
| version = "1.5.0" | ||
| version = "2.0.0" |
There was a problem hiding this comment.
The PR is technically non-breaking (since the removed functions are not public API) but in practice breaks old versions of Distributions that make use of these non-public functions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 70.88% 72.39% +1.51%
==========================================
Files 17 22 +5
Lines 838 1007 +169
==========================================
+ Hits 594 729 +135
- Misses 244 278 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think this is good. Are there other breaking changes that we can come up with before releasing this? |
|
Maybe we could even think about removing the |
I would be very in favor (especially because I am going to try very hard to remove all remaining rmath dependencies over the next ~2 weeks) |
|
In its current form, the PR removes the submodule. |
The
...randmethods inStatsFuns.RFunctionsbased on Rmath are not used in StatsFuns and not public API either. IMO if one wants to use these methods, it would be better to useRmathdirectly (see JuliaStats/Rmath.jl#91).The PR requires JuliaStats/Rmath.jl#91 and making use of Rmath in Distributions.
Additionally, to reduce the number of definitions further I removed the
StatsFuns.RFunctionssubmodule and only defined the publicly exposed functions directly in theStatsFunsmodule.