Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #243 +/- ##
===========================================
+ Coverage 77.22% 93.27% +16.05%
===========================================
Files 24 24
Lines 1190 1190
===========================================
+ Hits 919 1110 +191
+ Misses 271 80 -191 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adonet allocated its work arrays with `Vector{Float64}(100)`, which
requires `undef` since Julia 1.0, so tvtcdf threw for most inputs.
Add tvtcdf tests against the orthant probability and for invariance
under relabeling the variables.
Fixes #242
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`JET.report_package` in the QA tests only printed its findings, so it did not catch #242 even though JET flags it. Use `JET.test_package`, which runs the same analysis and records a test failure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
devmotion
force-pushed
the
dmw/fix-tvtcdf-undef
branch
from
November 16, 2026 12:54
f5f9017 to
24c1586
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #242.
adonetallocated its work arrays withVector{Float64}(100), which needsundefsince Julia 1.0.tvtcdfcallsadonetwhenever no special case applies, so most inputs threw aMethodError.Tests added for
tvtcdfwithnu= 0, 1, 3, 30:h = 1e-15(just large enough that theh ≈ 0shortcut is skipped and the numerical integration runs), the result matches the orthant probability1/8 + Σ asin(r) / 4πtortol = 1e-13;h3 = 1e15, the result matchesbvtcdfof the remaining two variables tortol = 1e-13(fornu ≥ 1,bvtcdfuses a separate closed-form algorithm);rtol = 1e-14.The new tests error without the fix.
JET already flagged this bug, but
test/qa.jlcalledJET.report_package, which only prints its findings. It now callsJET.test_package, which runs the same analysis and fails the test on any report. JET reports nothing on this branch, and the test fails if the bug is reintroduced.🤖 Generated with Claude Code