Fix lambda theory test#236
Conversation
…nts of eclasses for which the semantic value has changed.
There was a problem hiding this comment.
@0x0f0f0f for what it's worth, I read through this bug fix and it seems correct to me, at least with respect to my understanding as captured in this comment:
Metatheory.jl/src/EGraphs/egraph.jl
Lines 77 to 85 in 107da67
In retrospect, if I had paid more attention while writing that comment, I could have caught this...
|
Let me add a few more test assertions to check the free variable analysis before merging this. |
|
Nice, can you trigger CI here as well pleae? |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## ale/3.0 #236 +/- ##
==========================================
Coverage ? 80.78%
==========================================
Files ? 19
Lines ? 1504
Branches ? 0
==========================================
Hits ? 1215
Misses ? 289
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@gkronber ok to merge? |
PR for #235.
Fixes semantic analysis code for lambda theory test case and a bug which caused missing updates of parent eclasses after the semantic value of an eclass was changed.