Add rule based integration method#12
Conversation
| @register_symbolic SymbolicUtils.expinti(x) | ||
| @register_symbolic SymbolicUtils.expint(nu, z) | ||
| @register_symbolic SymbolicUtils.gamma(x, y) | ||
| @register_symbolic SymbolicUtils.sinint(x) | ||
| @register_symbolic SymbolicUtils.cosint(x) |
| @@ -0,0 +1,247 @@ | |||
| using Symbolics | |||
There was a problem hiding this comment.
| using Symbolics |
usings at top level
| @@ -0,0 +1,119 @@ | |||
| include("string_manipulation_helpers.jl") | |||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
|
okay I removed all that stuff from the README and moved it to the documentation. The documentation is still messy, I want to improve it but I need some time to write it properly and now I need to go. But the README should be ready, tell me if you like it. |
|
Okay to get things merged here, let's split this into now vs follow ups:
|
| verbose=method.verbose, use_gamma=method.use_gamma, kwargs...) | ||
| end | ||
|
|
||
| <<<<<<< HEAD |
ChrisRackauckas
left a comment
There was a problem hiding this comment.
If tests pass I think this is reasonable to merge now. Of course, still much to do, but we can take the next steps in stages.
|
Looks like some test failures. |
|
yes the tests were failing because the includes were in the wrong order. I didn't think order mattered but apparently it does |
|
sorry, now should work |
@ChrisRackauckas I moved the registrations to Symbolics.jl with this pr JuliaSymbolics/Symbolics.jl#1642 , I only moved there the ones definied in SymboliUtils, and not the ones definied in the packages Elliptic, HypergeometricFunctions, PolyLog and FresnelIntegrals, because they are not imported by Symbolics |
Those extensions could all be in Symbolics. Basically the code that is here could just copy-paste move to be extensions there. |
work in progress