Handle identity-wrapped constants in Maxima serializer#120
Handle identity-wrapped constants in Maxima serializer#120Amin-El-Sayed wants to merge 5 commits into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 50.98% 54.51% +3.52%
==========================================
Files 23 23
Lines 4309 4309
==========================================
+ Hits 2197 2349 +152
+ Misses 2112 1960 -152 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I also bumped the SymbolicIntegrationMaxima subpackage version to 0.1.2 in this PR. Reason: after this is merged, the correct registry path is to register a new SymbolicIntegrationMaxima version from |
|
Follow-up pushed: the remaining basic CI failures were order-sensitive serialization tests. Symbolics/SymbolicUtils may reorder commutative sums/products across Julia/dependency versions, e.g. |
Fixes a Maxima serialization failure for expressions where Symbolics wraps constants such as
pi/πinidentity(...).Example fixed:
Changes:
identity(arg)asargfor Maxima inputπ * x∫_0^L sin(πx/L)^2 dx = L/2underL > 0Validation: