Specialize in(x::Union{Sym,Term,Num}, I::TypedEndpointsInterval)#797
Open
jishnub wants to merge 4 commits intoJuliaSymbolics:masterfrom
Open
Specialize in(x::Union{Sym,Term,Num}, I::TypedEndpointsInterval)#797jishnub wants to merge 4 commits intoJuliaSymbolics:masterfrom
in(x::Union{Sym,Term,Num}, I::TypedEndpointsInterval)#797jishnub wants to merge 4 commits intoJuliaSymbolics:masterfrom
Conversation
Along with JuliaMath/IntervalSets.jl#126, this helps avoid ambiguities such as in JuliaApproximation/ApproxFun.jl#847
in(x::Num, I::AbstractInterval)in(x::Union{Sym,Term,Num}, I::AbstractInterval)
in(x::Union{Sym,Term,Num}, I::AbstractInterval)in(x::Union{Sym,Term,Num}, I::TypedEndpointsInterval)
shashi
reviewed
Mar 17, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #797 +/- ##
==========================================
- Coverage 76.83% 76.81% -0.03%
==========================================
Files 26 26
Lines 3238 3239 +1
==========================================
Hits 2488 2488
- Misses 750 751 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Is there some progress on that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Along with JuliaMath/IntervalSets.jl#126, this helps avoid ambiguities such as in JuliaApproximation/ApproxFun.jl#847
Let's wait for a decision on JuliaMath/IntervalSets.jl#126 before thisEdit: I've updated this to define
inforTypedEndpointsInterval. AddingIntervalSetsas a dependency does not impact load times, as it's loaded byDomainSetsanyway. WhileTypedEndpointsIntervalis not exported byIntervalSets, it's quite a fundamental type as, among other things,IntervalandChebyshevIntervalare subtypes of this.With this PR, the following works: