Fix Vararg handling on v1.7+ #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopher-dG
force-pushed
the
cdg/vararg
branch
from
a9e0251 to
d271006
Compare
christopher-dG
force-pushed
the
cdg/vararg
branch
from
d271006 to
0737212
Compare
|
Fun stuff: on 1.7, the tests take 10 minutes to fail vs 3 minutes for 1.6. Puzzling, but not my problem for now 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 1.7,
typeof(Vararg)is no longerUnionAll, it'sCore.TypeofVararg, which has fieldsTandN. Unfortunately we still have the errors that 1.6 has, which means this package remains mostly unusable 🙃